Prefix exported symbols via UnmanagedCallersOnly attribute#79880
Prefix exported symbols via UnmanagedCallersOnly attribute#79880ivanpovazan merged 4 commits intodotnet:mainfrom
Conversation
|
I have two questions regarding this change:
|
Since iOS/tvOS doesn't run on PR's, it would be better to add a test for osx. |
60aac23 to
0efc36b
Compare
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
@steveisok, regarding your comment: Afaik calling exported symbols is supposed to work only in full AOT mode, which makes the testing of this feature really specific. Does that make sense? Additionally, with this change I also had to adapt: https://github.com/ivanpovazan/runtime/blob/unmanagedcallersonly-mangling/src/mono/msbuild/apple/build/AppleApp.targets#L143 |
|
Failures are unrelated |
Yeah, you're right in that we don't run many full aot legs. I'm fine with it. It looks like the tvOS run timed out. |
|
Created a separate PR to enable specifying custom native main for functional tests: #80546 |
…y attribute with an underscore on Apple platforms
7dd0df2 to
b76425a
Compare
…allbackAttribute" This reverts commit b76425a.
|
Mentioning: dotnet/macios#10470 for a reference |
This PR includes the following:
UnmanagedCallersOnlyAttributewill be prefixed with a required_on Apple platforms (as it is expected by the linker and dlsym)MonoPInvokeCallbackAttributewill not be prefixed (in order to prevent breaking existing code)Fixes: #79491
/cc: @steveisok @mdh1418 @lateralusX