[release/7.0] Disable mark phase prefetching for segments#78925
[release/7.0] Disable mark phase prefetching for segments#78925carlossanlop merged 1 commit intorelease/7.0from
Conversation
…ll using segments as a fallback for customers hitting issues with regions.
ghost
added
the
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #78803 to release/7.0 /cc @PeterSolMS Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
Please fill out the template. Request approval from Jeff Schwartz. If approved, add the servicing-consider label and send email to Tactics, then get a code review sign-off and verify CI is green. Friendly reminder that the window for merging backports this month is only going to be of one day (29th-30th) so I want to make sure everything is ready for me to just press "merge" when the branch opens. |
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we will take for consideration in 7.0.x
jeffschwMSFT
added
the
Servicing-consider
rbhanda
added
Servicing-approved
|
Branding has been done. Milestone is 7.0.2. Signed-off by area owners. Approved by Tactics. No OOB package authoring changes needed. CI is green. |
4 participants
Backport of #78803 to release/7.0
/cc @PeterSolMS
Customer Impact
Idea behind this change is to give customers a workaround if they encounter issues with the GC changes in .NET Core 7.0. One change was the introduction of mark phase prefetching, so this change disables this for segments. Thus, when customers switch to clrg.dll as their GC, they will have behavior as close as possible to .NET Core 6.0.
Testing
Ran GCPerfSim scenarios, inspect generated code to ensure the right thing is happening both with and without mark phase prefetch.
Risk
Low, because there is no change for the GC in coreclr.dll, and the GC in clrgc.dll disables a new feature in 7.0.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.