Use IndexOfAnyValues in CoreLib#78678
Merged
MihaZupan merged 2 commits intodotnet:mainfrom Nov 22, 2022
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsContributes to #78204 Avoids the cost of initializing the
In this case we're using As ASCII values are more common in these cases, we could consider adding while (remaining > vector256)
{
var vector = Vector256.LoadUnsafe(...);
if (AllCharsAreAscii(vector))
{
IndexOfAnyAsciiSearcher.Lookup(vector, _bitmap);
}
else
{
// Fallback to ProbabilisticMap or even IndexOfAny(char, char, char)
}
}
|
stephentoub
reviewed
Nov 22, 2022
stephentoub
approved these changes
Nov 22, 2022
This was referenced Nov 22, 2022
Member
Author
|
The checked arm64 failures are #78718 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #78204
Avoids the cost of initializing the
ProbabilisticMapon every matched value forReplaceLineEndings.In this case we're using
"\r\n\f\u0085\u2028\u2029"as the needle.We also have a bunch of uses of
char.IsWhiteSpacewhere the needle likewise contains both ASCII and non-ASCII chars.As ASCII values are more common in these cases, we could consider adding
IndexOfAnyValuesimplementations with loops like this in the future: