[release/7.0] Fix Equals in hot reload scenario#78258
Merged
carlossanlop merged 2 commits intorelease/7.0from Nov 14, 2022
Merged
[release/7.0] Fix Equals in hot reload scenario#78258carlossanlop merged 2 commits intorelease/7.0from
carlossanlop merged 2 commits intorelease/7.0from
Conversation
…nCacheTests.cs Co-authored-by: Steve Harter <steveharter@users.noreply.github.com>
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsBackport of #78249 to release/7.0 /cc @buyaa-n Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
buyaa-n
requested review from
AaronRobinsonMSFT,
ericstj,
jkotas and
steveharter
jkotas
approved these changes
Nov 12, 2022
AaronRobinsonMSFT
approved these changes
Nov 12, 2022
Contributor
|
Approved for servicing by email, updating the label with approved The failure unrelated and related issue is linked |
buyaa-n
added
Servicing-approved
steveharter
approved these changes
Nov 14, 2022
Contributor
|
CI failure is known and unrelated: #77988 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #78249 to release/7.0
/cc @buyaa-n
Description
While fixing Hot Reload breaks MethodInfo equality we caused regression in .NET 7 Huge Breaking Issue in Net7 with MemberInfo equality
Customer Impact
The regression causes wrong equality check result for derived members of a Type when hot reload enabled. As hot reload is enabled by default in VS it could cause failures for any customer that uses Reflection and debugging their code. They would need to disable hot reload to be able to debug further
Testing
Added unit tests that reproes the issue
Risk
Low, the fix adds one additional check (of
ReflectedTypes) but only affects hot reload scenariosIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.