[hot_reload] implement param reflection#77563
Merged
lambdageek merged 15 commits intodotnet:mainfrom Nov 2, 2022
Merged
Conversation
lambdageek
requested review from
marek-safar,
thaystg and
vargaz
as code owners
ghost
added
the
Member
Author
|
I would like to backport this for 7.0.x servicing to unblock MAUI XAML hot reload scenarios |
vargaz
approved these changes
Oct 27, 2022
lambdageek
commented
Oct 27, 2022
lambdageek
commented
Oct 27, 2022
lambdageek
force-pushed
the
fix-gh-77512
branch
3 times, most recently
from
862aaaa to
8e610e2
Compare
lambdageek
force-pushed
the
fix-gh-77512
branch
from
8e610e2 to
55b2892
Compare
lambdageek
force-pushed
the
fix-gh-77512
branch
from
406db89 to
9d923b2
Compare
otherwise the CancellationToken type is trimmed on wasm
lambdageek
force-pushed
the
fix-gh-77512
branch
from
70e3530 to
ded76bb
Compare
remove duplicated code
lambdageek
force-pushed
the
fix-gh-77512
branch
from
f60d978 to
42e43e5
Compare
Member
Author
|
@vargaz mind taking another look? same approach as before, but I put all the logic about figuring out the first & last param of a method into a separate function even for the non-update case. removed a bunch of copy/pasted code |
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
Member
Author
|
/backport to release/7.0 |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3371579628 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #77512
When a method is added, the paramlist column in the MethodDef is empty. Instead, the parameter info is added by separate EnCLog "Add Param" commands. Store that info in the image, keyed on the method definition token.