Merged
Conversation
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
pavelsavara
commented
Oct 25, 2022
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Oct 25, 2022
16b5ee6 to
1df3637
Compare
radical
reviewed
Oct 26, 2022
Member
radical
left a comment
There was a problem hiding this comment.
incomplete review, just sharing some comments.
lambdageek
reviewed
Nov 1, 2022
Member
lambdageek
left a comment
There was a problem hiding this comment.
LGTM except there seems to be some copy/paste errors in the invoke-cs methods
vargaz
reviewed
Nov 1, 2022
vargaz
reviewed
Nov 1, 2022
vargaz
reviewed
Nov 1, 2022
vargaz
reviewed
Nov 1, 2022
vargaz
reviewed
Nov 1, 2022
lambdageek
approved these changes
Nov 1, 2022
lewing
approved these changes
Nov 1, 2022
radical
added a commit
to radical/runtime
that referenced
this pull request
Nov 1, 2022
This reverts commit 0e24ea7. This breaks with v8 10.9.130 with: ``` Error: Invalid 'startMark' argument: No numeric 'startTime' field at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994) at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874 exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field ``` It works fine with older versions like `10.7.193` (current stable).
radical
added a commit
that referenced
this pull request
Nov 2, 2022
This reverts commit 0e24ea7. It broke all the perf pipeline wasm builds. It happens with v8 `10.9.130`: ``` Error: Invalid 'startMark' argument: No numeric 'startTime' field at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994) at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874 exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field ``` - It works fine with older versions like `10.7.193` (current stable). - It wasn't caught in the CI checks because those are using an older version of v8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reporting both interpreter, AOT and some Javascript calls directly to chrome dev tools via
performance.measure()Chrome

FireFox

Profiler
src\mono\mono\profiler\browser.conly for WASM platformperformance.measureAPIUsage
And
And start profiling in browser dev tools
Notes
Future work
Changes
browser.clibmono-profiler-browser.ait is always linked into dotnet.wasm in both Debug and Release configurations--profilerargument to AOT compilerContributes to #76316