[release/7.0] fix div by zero in gen size calculation#76334
Merged
carlossanlop merged 1 commit intorelease/7.0from Sep 29, 2022
Merged
[release/7.0] fix div by zero in gen size calculation#76334carlossanlop merged 1 commit intorelease/7.0from
carlossanlop merged 1 commit intorelease/7.0from
Conversation
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #76294 to release/7.0 /cc @Maoni0 Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
mangod9
approved these changes
Sep 28, 2022
Contributor
|
@Maoni0 if this is ready, can you please add the |
Contributor
|
Approved by Tactics via email. Signed off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #76294 to release/7.0
/cc @Maoni0
Customer Impact
This was reported with #76257. It's a bug that only shows up with regions. With segments, because we always allocate a min object in each generation to indicate the generation start, the size can never be 0. With regions we no long need to but this also means a generation size can be 0. The workaround is unacceptable to the customer -
Testing
I tested this under the debugger. I can see the div zero exception and with the fix I no longer see it.
Risk
Not for a servicing release.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.