Fix public key token of Serialization.Schema contract assembly#75963
Merged
ViktorHofer merged 2 commits intomainfrom Sep 21, 2022
Merged
Fix public key token of Serialization.Schema contract assembly#75963ViktorHofer merged 2 commits intomainfrom
ViktorHofer merged 2 commits intomainfrom
Conversation
The Microsoft public key token was only applied to the source assembly but not to the contract.
ViktorHofer
changed the title
ViktorHofer
changed the title
eerhardt
approved these changes
Sep 21, 2022
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
LGTM. How did you catch this?
Member
Author
|
With the new roslyn-based APICompat tooling that we are migrating to via #73263 (comment). The tooling flagged the in-compatibility between the contract and the implementation. |
Member
Author
|
/backport to release/7.0 |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3098867926 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Microsoft public key token was only applied to the source assembly but not to the contract. Fixing this by moving the StrongNameKey property into the parent Directory.Build.props file, same as we do for other libraries.
I think we should backport this change into release/7.0 to avoid potential customer observable issues.