[MONO] Move Marshal-ilgen into a component#75542
Merged
naricc merged 17 commits intodotnet:mainfrom Nov 15, 2022
Merged
Conversation
This was referenced Sep 29, 2022
naricc
force-pushed
the
naricc/marshal-component
branch
2 times, most recently
from
9587a95 to
f84b181
Compare
naricc
changed the title
naricc
requested review from
SamMonoRT,
lambdageek,
lewing,
marek-safar,
pavelsavara,
radical,
thaystg and
vargaz
as code owners
Member
|
@naricc you need to resolve the merge conflicts before the CI pipelines will run |
naricc
force-pushed
the
naricc/marshal-component
branch
from
62c3d76 to
4e0e605
Compare
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Nov 3, 2022
Contributor
Author
|
/azp run runtime-extra-platforms |
Contributor
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
naricc
force-pushed
the
naricc/marshal-component
branch
from
9a02194 to
091aa36
Compare
Contributor
Author
|
/azp run runtime-extra-platforms |
Contributor
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
lambdageek
reviewed
Nov 14, 2022
added 7 commits
November 14, 2022 16:19
Contributor
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lambdageek
approved these changes
Nov 15, 2022
Member
lambdageek
left a comment
lambdageek
left a comment
There was a problem hiding this comment.
LGTM. I'm excited that we finally have a chance to clean things up here
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
/azp run runtime-wasm |
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Nov 18, 2022
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move marhsal-ilgen into a component, ultimately saving approximately 100kb in the runtime when the component is not needed. This addresses issues seen on iOS last time this was attempted, and fixes a race condition.
I am still doing manual testing on xamarin-ios and xamarin-android, but think this is ready for review.