[release/7.0] JIT: Fix unrecognized unaligned field indirections on ARM32#75250
Merged
carlossanlop merged 1 commit intorelease/7.0from Sep 8, 2022
Merged
[release/7.0] JIT: Fix unrecognized unaligned field indirections on ARM32#75250carlossanlop merged 1 commit intorelease/7.0from
carlossanlop merged 1 commit intorelease/7.0from
Conversation
For large field offsets we need to insert explicit null checks. This was breaking recognition of unaligned accesses that needs special treatment for floating point instructions. Fix #74260
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #75078 to release/7.0 /cc @jakobbotsch Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
jeffschwMSFT
approved these changes
Sep 8, 2022
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. please get a code review and once we have a green ci we can merge
Member
|
CC @kunalspathak please code review for backport. |
Contributor
|
Approved, signed off, CI is green. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #75078 to release/7.0
/cc @jakobbotsch
Customer Impact
On ARM32, accessing unaligned float fields at large offsets may cause a data alignment exception.
Testing
Regression test included.
Risk
Low. Targeted fix.