Closed
Conversation
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsThis change fixes #75207. When we For reviewers, I assumed (i.e. please check):
|
mangod9
reviewed
Sep 7, 2022
Maoni0
reviewed
Sep 7, 2022
cshung
commented
Sep 20, 2022
cshung
commented
Sep 20, 2022
1d9c776 to
b20a14f
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes #75207.
When we
init_heap_segment, we preserve theheap_segment_flags_ma_committed, and before wecommit_mark_array_new_seg, we check the flag first and avoid recommitting.For reviewers, I assumed (i.e. please check):
USE_REGIONS, or it is for frozen segments where by design it can never overlap with the region reserved range, andheap_segment_flags_ma_pcommittedturned on underUSE_REGIONS.