Fix Exp10M1(TSelf) and Round(TSelf, MidpointRounding)#75063
Fix Exp10M1(TSelf) and Round(TSelf, MidpointRounding)#75063tannergooding merged 8 commits intodotnet:mainfrom
Exp10M1(TSelf) and Round(TSelf, MidpointRounding)#75063Conversation
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue Details
Fixes #75059
|
|
I apologize for the lack of tests -- I'm currently experiencing connectivity issues, which makes cloning and building the runtime a bit tricky. I'm writing some right now for both of the functions that I fixed, but if needed I can try to add more while I wait for my internet to come back. Sorry for submitting this PR without the tests first |
Absolutely no worries. We'd much rather have a fix up than not at all. Someone else can always pick it up and add tests if necessary/etc 😄 |
src/libraries/System.Runtime/tests/System/Numerics/GenericMathDimHelpers.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System/Numerics/GenericMathDimHelpers.cs
Outdated
Show resolved
Hide resolved
tannergooding
left a comment
There was a problem hiding this comment.
Changes LGTM. Just a few minor nits to use float instead of using Single
src/libraries/System.Runtime/tests/System/Numerics/GenericMathDimHelpers.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System/Numerics/IExponentialFunctionsTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System/Numerics/IFloatingPointTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System/Numerics/IFloatingPointTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System/Numerics/IFloatingPointTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System/Numerics/IFloatingPointTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System/Numerics/IFloatingPointTests.cs
Outdated
Show resolved
Hide resolved
dakersnar
left a comment
There was a problem hiding this comment.
LGTM, and thanks for submitting unit tests too.
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3016956207 |
IExponentialFunctions.Exp10M1had a typo that caused it to go into infinite recursion, andIFloatingPoint.Roundstraight up just ignored it'smodeargument, most likely just a typo again.Fixes #75059