[wasm] Fix JSExport on struct and records#74763
Merged
maraf merged 11 commits intodotnet:mainfrom Aug 31, 2022
Merged
Conversation
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
reviewed
Aug 29, 2022
...ices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/JavaScriptTestHelper.mjs
Outdated
Show resolved
Hide resolved
radical
reviewed
Aug 29, 2022
...aries/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/JSImportStubContext.cs
Outdated
Show resolved
Hide resolved
radical
reviewed
Aug 29, 2022
...aries/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/JSImportStubContext.cs
Outdated
Show resolved
Hide resolved
radical
reviewed
Aug 29, 2022
...aries/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/JSImportStubContext.cs
Outdated
Show resolved
Hide resolved
radical
reviewed
Aug 29, 2022
...vices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/JavaScriptTestHelper.cs
Outdated
Show resolved
Hide resolved
radical
reviewed
Aug 29, 2022
...aries/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/JSImportStubContext.cs
Outdated
Show resolved
Hide resolved
radical
reviewed
Aug 29, 2022
...vices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/JavaScriptTestHelper.cs
Show resolved
Hide resolved
pavelsavara
approved these changes
Aug 31, 2022
radical
reviewed
Aug 31, 2022
...aries/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/JSImportStubContext.cs
Outdated
Show resolved
Hide resolved
radical
reviewed
Aug 31, 2022
...aries/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/JSImportStubContext.cs
Outdated
Show resolved
Hide resolved
radical
reviewed
Aug 31, 2022
...vices.JavaScript.UnitTests/System/Runtime/InteropServices/JavaScript/JavaScriptTestHelper.cs
Show resolved
Hide resolved
radical
approved these changes
Aug 31, 2022
Member
radical
left a comment
radical
left a comment
There was a problem hiding this comment.
Other than the comments, LGTM 👍
Member
Author
|
/backport to release/7.0 |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2966642862 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSExporton structs, record classes and record structs.JSExport.