[release/6.0] App does not Run as a service in a Windows Container#74188
[release/6.0] App does not Run as a service in a Windows Container#74188carlossanlop merged 2 commits intodotnet:release/6.0from
Conversation
Removing SessionId check in IsWindowsService(). This check is not correct when the process is being run in a Windows container. The container will get a different SessionId. Fix dotnet#52416
eerhardt
added
Servicing-consider
|
Tagging subscribers to this area: @dotnet/area-extensions-hosting Issue DetailsBackport of #62452 to release/6.0 Customer ImpactWhen an ASP.NET service or a "generic hosted" app is executed as a Windows Service inside a Windows Container, it isn't getting the right lifetime. This makes the app not start correctly. The reason is because inside a Windows Container, the Windows "SessionId" isn't set to TestingManually tested in a Windows Service on a normal machine, plus inside a Windows Container. As well as tested the method still produces There are no automated tests for this scenario since:
RiskLow Risk. The change has been in Fix #70751
|
|
For the September release or for next month? cc @mmitche @danmoseley |
I'd be happy with whenever it can be approved and merged. There's no rush - I just have been pinged on backporting this fix multiple times, and now have a little bit of time to get it in the pipeline. |
|
This was approved via email by Tactics. |
carlossanlop
added
Servicing-approved
|
Branding was done, so the branch is open again for changes. Merging now since it got approved, OOB package authoring changes were properly added, and the CI passed. |
They were introduced in September in these 3 PRs: - Microsoft.Extensions.DependencyInjection: dotnet#74366 - Microsoft.Extensions.Hosting.WindowsServices: dotnet#74188 - Microsoft.NETCore.Platforms (RIDs): dotnet#74383
* Update branding to 6.0.11 * Reseting OOB package authoring changes. They were introduced in September in these 3 PRs: - Microsoft.Extensions.DependencyInjection: #74366 - Microsoft.Extensions.Hosting.WindowsServices: #74188 - Microsoft.NETCore.Platforms (RIDs): #74383 Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
ghost
locked as resolved and limited conversation to collaborators
3 participants
Backport of #62452 to release/6.0
Customer Impact
When an ASP.NET service or a "generic hosted" app is executed as a Windows Service inside a Windows Container, it isn't getting the right lifetime. This makes the app not start correctly.
The reason is because inside a Windows Container, the Windows "SessionId" isn't set to
0.Testing
Manually tested in a Windows Service on a normal machine, plus inside a Windows Container. As well as tested the method still produces
falsewhen not running as a Windows Service in both "normal" and containers.There are no automated tests for this scenario since:
Risk
Low Risk. The change has been in
main/7.0 since December without any complaints/concerns popping up.Fix #70751