[release/7.0-rc1] net7.0 + net6.0 workload multitargeting changes by lewing · Pull Request #74018 · dotnet/runtime

lewing · 2022-08-16T17:36:49Z

No description provided.

ghost · 2022-08-16T17:37:06Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:	lewing
Assignees:	-
Labels:	`area-System.Net`
Milestone:	-

ghost · 2022-08-16T17:40:19Z

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:	lewing
Assignees:	lewing
Labels:	`area-System.Net`, `area-Infrastructure-mono`
Milestone:	-

…7 but NOT in 6. Dotnet workload install wasm-tools-net6 should install a different set of components than wasm-tools

…that workload

…oad-changes

Don't use **FromWorkload** for pack versions because it doesn't understand the name aliasing we have to use with runtime packs

radical · 2022-08-20T04:01:24Z

/azp run runtime, runtime-staging

azure-pipelines · 2022-08-20T04:01:56Z

Azure Pipelines successfully started running 2 pipeline(s).

When running a fresh build with `dotnet build`, the first one works fine. But all the subsequent builds fail with no info in the logs at all. ``` $ /workspaces/runtime/artifacts/bin/dotnet-net7/dotnet build MSBuild version 17.4.0-preview-22413-01+f0a66ec43 for .NET Build FAILED. 0 Warning(s) 0 Error(s) ``` And it seems to be related to msbuild nodes, so disable NodeReuse.

…ng-net7-workload-changes

lewing · 2022-08-21T19:34:00Z

@dsplaisted @marcpopMSFT

      [] /datadisks/disk1/work/93E60831/w/A8A8094E/e/dotnet-net7/sdk/7.0.100-rc.2.22419.24/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(219,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [/datadisks/disk1/work/93E60831/w/A8A8094E/e/blz_aot_prj_file_Release/blz_aot_prj_file_Release.csproj]
      [] /datadisks/disk1/work/93E60831/w/A8A8094E/e/dotnet-net7/sdk/7.0.100-rc.2.22419.24/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(448,5): error NETSDK1109: Runtime list file '/datadisks/disk1/work/93E60831/w/A8A8094E/e/dotnet-net7/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/data/RuntimeList.xml' was not found. Report this error to the .NET team here: https://aka.ms/dotnet-sdk-issue. [/datadisks/disk1/work/93E60831/w/A8A8094E/e/blz_aot_prj_file_Release/blz_aot_prj_file_Release.csproj]

it appears to be looking up the runtime pack in the packs directory without a version on the pack

/datadisks/disk1/work/93E60831/w/A8A8094E/e/dotnet-net7/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/data/RuntimeList.xml doesn't exist but /datadisks/disk1/work/93E60831/w/A8A8094E/e/dotnet-net7/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/7.0.0-ci/data/RuntimeList.xml does

lewing · 2022-08-21T22:10:53Z

@marcpopMSFT could it be dotnet/sdk@0bc1ff8

lewing · 2022-08-22T01:20:20Z

Found the issue on our side, the tests were including a bunch of outdated logic that was breaking things

radical · 2022-08-22T01:29:32Z

Approved, assuming the CI is green.

radical

Assuming the ci is green

akoeplinger · 2022-08-22T08:53:00Z

src/tests/BuildWasmApps/Wasm.Build.Tests/BuildEnvironment.cs

+            // second, and subsequent builds fail without any details
+            // in the logs
+            EnvVars["DOTNET_CLI_DO_NOT_USE_MSBUILD_SERVER"] = "1";
+            DefaultBuildArgs += " /nr:false";


do we have an issue filed for this?

It might be related to this one: dotnet/sdk#26965 (comment)
But with newer builds of the SDK, I was able to take out this workaround.

ghost added the area-System.Net label Aug 16, 2022

ghost assigned lewing Aug 16, 2022

hoyosjs added the area-Infrastructure-mono label Aug 16, 2022

hoyosjs removed the area-System.Net label Aug 16, 2022

lewing requested a review from jonathanpeppers August 16, 2022 17:41

marcpopMSFT mentioned this pull request Aug 16, 2022

.NET 7 support in MAUI dotnet/maui#9192

Closed

lewing changed the base branch from main to release/7.0-rc1 August 17, 2022 01:09

lewing changed the title ~~Net7 workload changes~~ [release/7.0-rc1] Net7 workload changes Aug 17, 2022

lewing closed this Aug 17, 2022

lewing reopened this Aug 17, 2022

lewing closed this Aug 17, 2022

lewing reopened this Aug 17, 2022

akoeplinger and others added 13 commits August 17, 2022 14:17

WIP

9a51d25

Update all the workload names to be net6 versions. This is needed in …

1dbf0c7

…7 but NOT in 6. Dotnet workload install wasm-tools-net6 should install a different set of components than wasm-tools

Add localization to net7 and correct localization for net6 to target …

77aaee9

…that workload

Update to 6.0.9 which should be the next version of emsdk.

45ecca2

Update the net7 and net6 workloads to rename all sdk packs

318b795

Use localize data from net7 project

5c6d14d

Fix typo

fa7628f

Fix typo

64c94be

Update KnownRuntimePack mono versions without clearing them all

2644c2f

Add net6.0 to description and fix up emscripten-net6 reference

3429497

Fix emsdk version number

32e11b9

depend on microsoft-net-sdk-emscripten-net7

d53636b

Fix missing .net7 renames

7ad680e

lewing force-pushed the net7-workload-changes branch from d9cd98e to 7ad680e Compare August 17, 2022 19:40

radical and others added 2 commits August 18, 2022 08:43

Merge remote-tracking branch 'origin/release/7.0-rc1' into net7-workl…

457fda2

…oad-changes

Update WorkloadManifest.targets.in

0f59d8f

Don't use **FromWorkload** for pack versions because it doesn't understand the name aliasing we have to use with runtime packs

radical and others added 5 commits August 19, 2022 20:22

More renames to fix builds

d8f9ca1

Merge branch 'release/7.0-rc1' into net7-workload-changes

15ed8c6

Update Versions.props

f8da8d3

Fix up a condition in WorkloadManifest.targets

ea8110e

Work around the import troubles

b21269b

lewing force-pushed the net7-workload-changes branch 2 times, most recently from 0dc04d2 to 3af277a Compare August 20, 2022 01:28

Work around the import troubles

4ac41be

lewing force-pushed the net7-workload-changes branch from 3af277a to 4ac41be Compare August 20, 2022 02:13

lewing added 2 commits August 19, 2022 21:35

Revert broken version check

0fe3b9d

Use BrowserWorkloadDisabled which will be set in both cases

72b3eea

lewing mentioned this pull request Aug 20, 2022

[release/7.0-rc1] Roll forward to the latest 6.0.x builds #74288

Merged

radical and others added 5 commits August 20, 2022 23:29

Fix typos in WorkloadManifest.targets

6a4f96c

Merge remote-tracking branch 'origin/net7-workload-changes' into lewi…

4d0cc0d

…ng-net7-workload-changes

cleanup

6630851

Merge branch 'release/7.0-rc1' into net7-workload-changes

3c7c2d6

Remove a bunch of stale logic from WBT

769a0fd

lewing requested a review from steveisok August 22, 2022 01:25

radical approved these changes Aug 22, 2022

View reviewed changes

lewing merged commit 754014e into release/7.0-rc1 Aug 22, 2022

lewing deleted the net7-workload-changes branch August 22, 2022 05:02

akoeplinger reviewed Aug 22, 2022

View reviewed changes

ghost locked as resolved and limited conversation to collaborators Sep 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release/7.0-rc1] net7.0 + net6.0 workload multitargeting changes#74018

[release/7.0-rc1] net7.0 + net6.0 workload multitargeting changes#74018
lewing merged 46 commits intorelease/7.0-rc1from
net7-workload-changes

lewing commented Aug 16, 2022

Uh oh!

ghost commented Aug 16, 2022

Uh oh!

ghost commented Aug 16, 2022

Uh oh!

radical commented Aug 20, 2022

Uh oh!

azure-pipelines bot commented Aug 20, 2022

Uh oh!

lewing commented Aug 21, 2022 •

edited

Loading

Uh oh!

lewing commented Aug 21, 2022

Uh oh!

lewing commented Aug 22, 2022

Uh oh!

radical commented Aug 22, 2022

Uh oh!

radical left a comment

Uh oh!

akoeplinger Aug 22, 2022

Uh oh!

jonathanpeppers Aug 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

lewing commented Aug 16, 2022

Uh oh!

ghost commented Aug 16, 2022

Uh oh!

ghost commented Aug 16, 2022

Uh oh!

radical commented Aug 20, 2022

Uh oh!

azure-pipelines bot commented Aug 20, 2022

Uh oh!

lewing commented Aug 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lewing commented Aug 21, 2022

Uh oh!

lewing commented Aug 22, 2022

Uh oh!

radical commented Aug 22, 2022

Uh oh!

radical left a comment

Choose a reason for hiding this comment

Uh oh!

akoeplinger Aug 22, 2022

Choose a reason for hiding this comment

Uh oh!

jonathanpeppers Aug 22, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lewing commented Aug 21, 2022 •

edited

Loading