Skip to content

Comments

[wasm] add new interop to the console template#72375

Merged
radekdoulik merged 15 commits intodotnet:mainfrom
alinpahontu2912:main
Jul 21, 2022
Merged

[wasm] add new interop to the console template#72375
radekdoulik merged 15 commits intodotnet:mainfrom
alinpahontu2912:main

Conversation

@alinpahontu2912
Copy link
Member

@alinpahontu2912 alinpahontu2912 commented Jul 18, 2022

First attempt at a working wasm console template

@ghost ghost added area-System.Console community-contribution Indicates that the PR has been added by a community member labels Jul 18, 2022
@dnfadmin
Copy link

dnfadmin commented Jul 18, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

@ghost
Copy link

ghost commented Jul 18, 2022

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

Issue Details

First attempt at a working wasm console template

Author: alinpahontu2912
Assignees: -
Labels:

area-System.Console
Milestone: -

@adamsitnik adamsitnik added arch-wasm WebAssembly architecture area-Build-mono and removed area-System.Console labels Jul 18, 2022
@ghost
Copy link

ghost commented Jul 18, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

First attempt at a working wasm console template

Author: alinpahontu2912
Assignees: -
Labels:

arch-wasm, area-System.Console, community-contribution
Milestone: -

pavelsavara
pavelsavara reviewed Jul 18, 2022
View reviewed changes
radekdoulik
radekdoulik reviewed Jul 18, 2022
View reviewed changes
radekdoulik
radekdoulik reviewed Jul 18, 2022
View reviewed changes
radekdoulik
radekdoulik reviewed Jul 18, 2022
View reviewed changes
radekdoulik
radekdoulik requested changes Jul 18, 2022
View reviewed changes
Copy link
Member

@radekdoulik radekdoulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just please fix white space in console.0.csproj. Looks like your editor replaced spaces with tabs in that file.

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 18, 2022
radekdoulik
radekdoulik reviewed Jul 18, 2022
View reviewed changes
radekdoulik
radekdoulik reviewed Jul 18, 2022
View reviewed changes
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 18, 2022
@radekdoulik radekdoulik changed the title Wasm console template [wasm] add new interop to the console template Jul 18, 2022
@radical
Copy link
Member

radical commented Jul 18, 2022

@alinpahontu2912 could you please merge main to your branch? It has fixes for the build failures here.

@radekdoulik
Copy link
Member

radekdoulik commented Jul 20, 2022

Alin is working on fixing the remaining test failure.

radical
radical reviewed Jul 20, 2022
View reviewed changes
@radekdoulik
Copy link
Member

radekdoulik commented Jul 21, 2022

The failing builds are unrelated.

@radekdoulik radekdoulik merged commit 70999d8 into dotnet:main Jul 21, 2022
@yamachu yamachu mentioned this pull request Jul 21, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radical radical radical left review comments

@radekdoulik radekdoulik radekdoulik approved these changes

@pavelsavara pavelsavara pavelsavara approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

No one assigned

Labels

arch-wasm WebAssembly architecture area-Build-mono community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alinpahontu2912 @dnfadmin @radical @radekdoulik @pavelsavara @adamsitnik