Merged
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsAfter #68986, we do not need it in block morphing. Includes additional cleanup of dead/unnecessary block morphing code. No diffs are expected.
|
Contributor
Author
|
@dotnet/jit-contrib |
43b14ff to
52cc4d2
Compare
EgorBo
approved these changes
Jun 29, 2022
Member
|
Thanks, let's wait for the active CI pipelines to finish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #68986, we do not need it in block morphing.
Includes additional cleanup of dead/unnecessary block morphing code.
Diffs - couple positive ones on x86 where we keep the block copy when assigning to a promoted SIMD.
Sample IR diff