Add System.Formats.Tar assembly to NetCoreAppLibrary.props#68343
Merged
carlossanlop merged 4 commits intodotnet:mainfrom Apr 21, 2022
carlossanlop:EnableTarAssemblyShipping
Merged
Add System.Formats.Tar assembly to NetCoreAppLibrary.props#68343carlossanlop merged 4 commits intodotnet:mainfrom carlossanlop:EnableTarAssemblyShipping
carlossanlop merged 4 commits intodotnet:mainfrom
carlossanlop:EnableTarAssemblyShipping
Conversation
carlossanlop
requested review from
ViktorHofer,
danmoseley,
ericstj and
jeffhandley
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsThis allows us to ship the assembly as part of the shared framework. Will need this change merged to main so it can be included in this preview4 backport PR: #68337
|
ViktorHofer
approved these changes
Apr 21, 2022
Member
There was a problem hiding this comment.
As you are already on it, can you please remove the PackageDescription as this library doesn't ship as an OOB: https://github.com/carlossanlop/runtime/blob/812f54f6d8e306ec609f1d078d9995e327bdfad7/src/libraries/System.Formats.Tar/src/System.Formats.Tar.csproj#L6-L14
Asking as devs looking at the lib will be confused regarding how the library ships.
Contributor
Author
|
@ViktorHofer done. |
ViktorHofer
approved these changes
Apr 21, 2022
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to ship the assembly as part of the shared framework.
Will need this change merged to main so it can be included in this preview4 backport PR: #68337