If the user has < 65 cores and passes in an affinitized range for the 0th CPU group, if valid, honor it.#68283
Conversation
…0th CPU group, honor that passed in affinitized range if valid.
…U Groups are available
… there are < 65 cores and the user passed in a config related to the 0th CPU Group
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsSummaryFor cases where the user is running on a machine with < 65 cores and has passed in a
NOTE: If both the Affinitized Range and the Affinitized Mask are passed, the Affinitized Mask is used if there are no CPU groups available on the machine. Implementation Details
|
…ask with CPU groups enabled, we error out since this case isn't valid
cshung
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for getting it fixed!
|
@janvorli would you like to take a look? |
|
Thanks for the feedback, @janvorli! I have incorporated them all and will merge these changes once the CI completes. |
Summary
For cases where the user is running on a machine with < 65 cores and has passed in a
GCHeapAffinitizeRangesfor just the 0th CPU group, apply the affinitized range rather than returning aCLR_E_GC_BAD_AFFINITY_CONFIG_FORMAT. And fail if:NOTE: If both the Affinitized Range and the Affinitized Mask are passed, the Affinitized Mask is used if there are no CPU groups available on the machine.
Implementation Details