Skip to content

Comments

[release/6.0] add RID for Ubuntu 22.04#66225

Merged
ericstj merged 1 commit intodotnet:release/6.0from
wfurt:60Ubu22
Mar 10, 2022
Merged

[release/6.0] add RID for Ubuntu 22.04#66225
ericstj merged 1 commit intodotnet:release/6.0from
wfurt:60Ubu22

Conversation

@wfurt
Copy link
Member

@wfurt wfurt commented Mar 4, 2022

This is manual port of #65483

I think RID changes don't need shiproom approval.
Let me know if you feel otherwise @carlossanlop

@wfurt wfurt added Servicing-consider Issue for next servicing release review area-Infrastructure-libraries labels Mar 4, 2022
@wfurt wfurt requested review from bartonjs and carlossanlop March 4, 2022 23:26
@wfurt wfurt self-assigned this Mar 4, 2022
@ghost
Copy link

ghost commented Mar 4, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

This is manual port of #65483

I think RID changes don't need shiproom approval.
Let me know if you feel otherwise @carlossanlop

Author: wfurt
Assignees: wfurt
Labels:

Servicing-consider, area-Infrastructure-libraries
Milestone: -

@teo-tsirpanis teo-tsirpanis added this to the 6.0.x milestone Mar 6, 2022
@runfoapp runfoapp bot mentioned this pull request Mar 7, 2022
Closed
@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Mar 8, 2022
@danmoseley
Copy link
Member

danmoseley commented Mar 8, 2022

I believe you're right, they don't need shiproom approval

carlossanlop
carlossanlop reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wfurt for my own education, why was the PR backported manually? I see that the original PR contains extra changes that renamed loongarch64 to armv6. Why was that change not needed here in the 6.0 branch?

Also, there were many CI failures. Can you please check if they are related to this infra change?

cc @bartonjs

@wfurt
Copy link
Member Author

wfurt commented Mar 8, 2022

I did not check @carlossanlop. I tried the automated way on #65483 and it failed.
But I guess we ant RID graphs to be the same AFAIK so perhaps this is something to investigate.

@ericstj ericstj modified the milestones: 6.0.x, 6.0.4 Mar 10, 2022
@ericstj
Copy link
Member

ericstj commented Mar 10, 2022

AOT failure is #66366
Staging failure is a timeout.
Dev-innerloop is a stale badge -- actual build succeeded 5 days ago.

@ericstj ericstj merged commit 4b3b700 into dotnet:release/6.0 Mar 10, 2022
@Mr-Tao Mr-Tao mentioned this pull request Mar 16, 2022
Closed
@omajid omajid mentioned this pull request Mar 17, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericstj ericstj ericstj approved these changes

@bartonjs bartonjs Awaiting requested review from bartonjs

+1 more reviewer

@carlossanlop carlossanlop carlossanlop left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@wfurt wfurt

Labels

area-Infrastructure-libraries Servicing-approved Approved for servicing release

Projects

None yet

Milestone

6.0.4

Development

Successfully merging this pull request may close these issues.

5 participants

@wfurt @danmoseley @ericstj @carlossanlop @teo-tsirpanis