Inline System.Boolean Parse helper methods

[L2]

• Profiling the boolean parse method showed that its
  helper methods weren't being inlined
• Increases performance on the System.Tests.Perf_Boolean.Parse*
  microbenchmarks

[ghost]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[L2]

summary:
better: 2, geomean: 7.583
total diff: 2

No Slower results for the provided threshold = 5% and noise filter = 0.3ns.

Faster	base/diff	Base Median (ns)	Diff Median (ns)	Modality
System.Tests.Perf_Boolean.Parse(value: "True")	7.97	21.99	2.76
System.Tests.Perf_Boolean.Parse(value: "False")	7.22	21.96	3.04

[danmoseley]

Thanks. It's unfortunately hard to make inlining decisions by running microbenchmarks - the microbenchmarks almost invariably get faster, but in a real app, the code can get significantly bigger.

If it's helpful to inline these, perhaps we should consider why they're not getting inlined.

[stephentoub]

The implementations can be streamlined with fewer reads:
#64782

[L2]

Thanks. It's unfortunately hard to make inlining decisions by running microbenchmarks - the microbenchmarks almost invariably get faster, but in a real app, the code can get significantly bigger.

If it's helpful to inline these, perhaps we should consider why they're not getting inlined.

Sounds good, I'll close this PR for now as @stephentoub 's implementation is the better way to go to extract more performance. Thanks again @danmoseley

The implementations can be streamlined with fewer reads: #64782

@stephentoub , very nice!

[danmoseley]

Do appreciate the attempt though @L2. There are lots of issues marked up for grabs if you want to look at another.

[danmoseley]

And we appreciate the inspiration here!

[stephentoub]

And we appreciate the inspiration here

Yeah I wouldn't have noticed if this PR didn't draw my eyes to it :-)