Add API entry for JsonDocument converter

[strobelt]

Fixes #59954 by adding an API entry for JsonDocument converter in the JsonMetadataServices

[ghost]

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #59954 by adding an API entry for JsonDocument converter in the JsonMetadataServices

Author:	strobelt
Assignees:	-
Labels:	area-System.Text.Json
Milestone:	-

[eiriktsarpalis]

I think more work is needed to wire the converter into the source generator implementation. Could you add a few tests as well?

[layomia]

I think more work is needed to wire the converter into the source generator implementation. Could you add a few tests as well?

👍

Ideally, we want to abstract the JsonDocument serializer tests (and possibly the JsonElement tests) to be shared between the reflection and src-gen implementations of the serializer. You can use the ExtensionDataTests.cs-related diffs in #58912 as an example.

We also need to add JsonDocument as a "known" type in the source generator implementation - e.g,

runtime/src/libraries/System.Text.Json/gen/JsonSourceGenerator.Parser.cs

Line 1462 in 5dc5e0d

AddTypeIfNotNull(_knownTypes, _jsonElementType);

[strobelt]

I fixed the naming conventions and added JsonDocument to the src-gen implementation.

But I am having a very hard time creating the tests needed. I read the changes on the PR #58912 and from what I understood there were two main changes:

• The System.Text.Json.SourceGeneration.Tests/Serialization/ExtensionDataTests.cs file was created with tests for the JsonExtensionDataAttribute
• The System.Text.Json/tests/Common/ExtensionDataTests.cs file was moved to Common and was made dependent on the SerializerTests

If I understood correctly the idea was to abstract the JsonDocument tests from Serialization\JsonDocumentTests.cs and \Serialization\DomTests.cs into a structure similar to what we have in both the ExtensionDataTests files. Is this correct? And if so, could you help me do this correctly?

Sorry for not being of more help with this, and thanks for all the help!

[eiriktsarpalis]

Hi @strobelt, we haven't had a chance to take a look at this yet. If you don't mind I will close this PR for now but we will revisit once we find the time to work on it.

[eiriktsarpalis]

I've rebased the changes and added a couple of simple unit tests. Rather than abstracting the existing JsonDocument/JsonElement suite, I included a couple of simple acceptance tests in the RealWorldContextTests class. We shouldn't need to replicate the full suite just to make sure we're wiring things correctly in the source generator.

[eiriktsarpalis]

Test failures unrelated, cf. #68293

[eiriktsarpalis]

Thank you for your contribution @strobelt!