Fix JSON src-gen errors when context types are not in namespaces#57183
Merged
layomia merged 1 commit intodotnet:mainfrom Aug 11, 2021
Merged
Fix JSON src-gen errors when context types are not in namespaces#57183layomia merged 1 commit intodotnet:mainfrom
layomia merged 1 commit intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsFixes #56920. FYI @Vake93 @stephentoub
|
23 tasks
steveharter
reviewed
Aug 11, 2021
| { | ||
| internal static partial class JsonConstants | ||
| { | ||
| public const string GlobalNamespaceValue = "<global namespace>"; |
Contributor
There was a problem hiding this comment.
Is this defined by Roslyn? (do they have a constant somewhere?)
Contributor
Author
There was a problem hiding this comment.
It's used in a few places in their repo, e.g. here, but not exposed publicly AFAIK .
steveharter
approved these changes
Aug 11, 2021
Contributor
steveharter
left a comment
steveharter
left a comment
There was a problem hiding this comment.
LGTM; test appears to validate the original issue
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56920. FYI @Vake93 @stephentoub