Sgen: Update GetTempAssemblyName according to #46499#57026
Merged
StephenMolloy merged 5 commits intodotnet:mainfrom Aug 17, 2021
TalAloni:TalAloni-Update-SGen-GetTempAssemblyName
Merged
Sgen: Update GetTempAssemblyName according to #46499#57026StephenMolloy merged 5 commits intodotnet:mainfrom TalAloni:TalAloni-Update-SGen-GetTempAssemblyName
StephenMolloy merged 5 commits intodotnet:mainfrom
TalAloni:TalAloni-Update-SGen-GetTempAssemblyName
Conversation
In #46499 we corrected Compilation.GetTempAssemblyName in order for it to be not deterministic under .NET Core. In this PR we update the generated filename to match the new logic.
ghost
added
area-Serialization
community-contribution
TalAloni
changed the title
TalAloni
changed the title
Avoid using external dependency
Avoid using external dependency
Fixed compilation
StephenMolloy
approved these changes
Aug 17, 2021
Member
StephenMolloy
left a comment
StephenMolloy
left a comment
There was a problem hiding this comment.
Question for @HongGit about the target framework, but otherwise this looks good. I'll let Hong have a chance to review and merge.
| return ReadUInt32BigEndian(hash); | ||
| } | ||
|
|
||
| private static uint ReadUInt32BigEndian(byte[] value) |
Member
There was a problem hiding this comment.
I assume we include our own implementation of ReadUInt32BigEndian() here because the framework version is netstandard2.1, while this tool targets netstandard2.0? If that's the case, I think this is fine.
@HongGit, do we have any plans to update the targetframework for this tool, or are we sticking to netstandard2.0?
Contributor
There was a problem hiding this comment.
For now, we are still sticking to netstandard2.0. If there is a need to update, we could consider to.
HongGit
approved these changes
Aug 17, 2021
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #46499 we corrected Compilation.GetTempAssemblyName in order for it to be not deterministic under .NET Core.
In this PR we update the generated filename to match the new logic.