Run just Android Arm64 System.Security.Cryptography.Pkcs.Tests#56861
Merged
mdh1418 merged 7 commits intodotnet:mainfrom Aug 6, 2021
Merged
Conversation
ghost
added
the
|
Tagging subscribers to this area: @directhex Issue DetailsEvaluating #37094
|
mdh1418
force-pushed
the
android_arm64_system_security_cryptography_pkcs
branch
from
1dd2077 to
2112f85
Compare
added 3 commits
August 4, 2021 15:50
stephentoub
approved these changes
Aug 5, 2021
Member
|
These still fail on the Android x64/x86 jobs in runtime-staging: https://dev.azure.com/dnceng/public/_build/results?buildId=1277052&view=logs&jobId=df0d4348-1948-576c-9bcf-0f0eaa3c5cab&j=b6e5d97f-d4f8-506b-9e47-e3e32385754a&t=94ce2805-f3e2-5f9a-1d92-0da5613f733d |
Member
|
Ah, yeah, these ones make the emulator run low on memory for some reason. We could never reproduce locally. |
steveisok
approved these changes
Aug 5, 2021
added 2 commits
August 5, 2021 11:51
Member
Author
|
System.Security.Cryptography.Pkcs.Tests no longer fails on CI from running out of memory after the change, the only failure in runtime-staging for Android is due to System.Runtime.InteropServices, which is addressed by #56909 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37094
This PR reenables System.Security.Cryptography.Pkcs.Tests on Android for x64,x86, arm64.
The tests run out of memory, especially when hitting
DecodeWithHighPbeIterationsas discovered by @akoeplinger , so we have opted to reduce the iteration count forDecodeWithHighPbeIterationsDatafor Android in order to still run the tests.