Add equality override for KeyValuePairComparer#56634
Merged
eiriktsarpalis merged 1 commit intodotnet:mainfrom Aug 2, 2021
Merged
Add equality override for KeyValuePairComparer#56634eiriktsarpalis merged 1 commit intodotnet:mainfrom
eiriktsarpalis merged 1 commit intodotnet:mainfrom
Conversation
src/libraries/System.Collections/src/System/Collections/Generic/SortedDictionary.cs
Show resolved
Hide resolved
Contributor
|
@johnthcall Did you create a PR for the benchmark? |
Contributor
Author
|
@drieseng I did not create a PR for the benchmark as I was just sharing the branch so that the reviewer could verify the validity of the benchmark results. Should a PR be made to cover these scenarios? |
Member
Adding the benchmark to dotnet/performance would be nice to have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that SortedDictionary copying was allocation more memory than iterating the initial dictionary and adding items one at a time. I realized that the optimization done as part of #45659 was not completely successful and we need to override Equals for KeyValuePairComparer so that SortedSets HasEqualComparer will pass to allow efficient deep copy.
dotnet/performance@main...johnthcall:johncall/SortedSetDeepCopy