Lsra heuristic tuning experiment report#56103
Merged
kunalspathak merged 3 commits intodotnet:mainfrom Jul 21, 2021
Merged
Conversation
ghost
added
the
area-CodeGen-coreclr
Contributor
Author
|
@dotnet/jit-contrib |
11 tasks
BruceForstall
approved these changes
Jul 21, 2021
Contributor
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
Thanks for writing this down.
It appears, but I think is not explicitly stated, that we didn't change the heuristic or heuristic ordering as a result of this experiment. Would it be reasonable to add some comment at the end to the effect of:
"We decided not to change any heuristic ordering at the current time as a result of this experiment. Instead, we will focus on fixing known LSRA issues as stated. After other LSRA weaknesses are addressed, we can choose to return to this experiment and use the techniques, tools, and knowledge here to inform a heuristic re-ordering."
?
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the draft that explains the background, motivation, experiments and outcome of LSRA heuristic tuning experiment.
Fixes #55376
Contributes to #43318