[release/6.0-preview7] [wasm] Add support for using custom native libraries #56013
Merged
mmitche merged 5 commits intodotnet:release/6.0-preview7from Jul 26, 2021
Merged
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
radical
added
the
NO-MERGE
(cherry picked from commit d574b03)
…otnet#55848) .. and fix logging that broke recently. `tasks/Common/Utils.cs`: TaskLoggingHelper Utils.Logger is a static field, which must be set by task else any methods in Utils, eg. RunProcess, silently fail to log any messages. Also, this would be a problem when building multiple projects in parallel, since the logger is a task-specific one. Instead, we pass logger as an arg to all the methods. (cherry picked from commit 3301e9d)
…net#55939) (cherry picked from commit 04072ff)
* [wasm] Add back --emit-llvm that got removed mistakenly, in an earlier commit .. found thanks to Jerome Laban. * [wasm] Set EmccCompile's messages to MessageImportance.Low by default. .. and to MessageImportance.Normal if `$(EmccVerbose)==true`. * [wasm] Quote filenames passed to emcc compile command line * Add more blazorwasm tests - for debug/release, aot/relinking * Bump sdk for workload testing to 6.0.100-rc.1.21370.2 * [wasm] Fix regression in compiling bitcode -> .o The `-emit-llvm` arg has been incorrectly added, and removed from the args used for compiling .bc->.o . This commit fixes it, and adds a crude test for it, so we don't regress again. * Fix build (cherry picked from commit 1d8ad03)
radical
force-pushed
the
backport-wasm-native-libs
branch
from
92e997c to
275c5b0
Compare
radical
removed
the
NO-MERGE
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackports:
The main update being (1) to add support for custom native libraries. The others essentially address some regressions in building the native bits, which resulted in increased build time, and file size. /cc @lewing @steveisok
|
radical
force-pushed
the
backport-wasm-native-libs
branch
from
275c5b0 to
d27d83c
Compare
Member
Author
This was referenced Jul 24, 2021
Closed
lewing
added
Servicing-consider
Member
|
Approved offline |
lewing
approved these changes
Jul 26, 2021
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports:
The main update being (1) to add support for custom native libraries. The others essentially address some regressions in building the native bits, which resulted in increased build time, and file size.
And the sdk version used to test against wasm workloads, is bumped to the latest preview7 build.
/cc @lewing @steveisok
Customer Impact
Allows customers use native libraries on Wasm, a highly requested feature we'd like feedback on and fixes build related regressions.
Regression?
Yes, includes fixes for size and build time regressions.
Risk
Low, restricted to Browser (and some mobile tasks).
Testing
Tests are included + manual testing.