increase default timout on RunClientServer methods#55798
Merged
stephentoub merged 1 commit intodotnet:mainfrom Jul 16, 2021
Merged
increase default timout on RunClientServer methods#55798stephentoub merged 1 commit intodotnet:mainfrom
stephentoub merged 1 commit intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsI've seen some timeouts while running parallel sets. Increasing the timeout improved my stability greatly. I no longer see
|
Member
|
@CarnaViire would this help the time-out your seeing in your PR? Maybe it's worth checking out instead of tedious investigations. |
Member
|
Also it might fix #55774 |
ManickaP
approved these changes
Jul 16, 2021
stephentoub
approved these changes
Jul 16, 2021
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
We should just have a general rule in in our tests: for timing out things we expect to succeed and a timeout indicates the test should fail, we shouldn't ever use timeouts less than at least 30s. :)
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've seen some timeouts while running parallel sets. Increasing the timeout improved my stability greatly. I no longer see
random timeouts.