Skip to content

Comments

Change RandomAccess.Write* methods to perform complete writes#55490

Merged
stephentoub merged 1 commit intodotnet:mainfrom
stephentoub:fixrandomaccesswritereturn
Jul 12, 2021
Merged

Change RandomAccess.Write* methods to perform complete writes#55490
stephentoub merged 1 commit intodotnet:mainfrom
stephentoub:fixrandomaccesswritereturn

Conversation

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Jul 12, 2021

Fixes #55473
Replaces #55474

@carlossanlop, @jozkee, @jeffhandley, I would like to get this in for Preview 7.

@ghost
Copy link

ghost commented Jul 12, 2021

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jul 12, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #55473
Replaces #55474

@carlossanlop, @jozkee, @jeffhandley, I would like to get this in for Preview 7.

Author: stephentoub
Assignees: -
Labels:

area-System.IO, new-api-needs-documentation
Milestone: -

@stephentoub stephentoub mentioned this pull request Jul 12, 2021
Closed
adamsitnik
adamsitnik approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for saving us! Now I can truly log off for the vacations.

@stephentoub stephentoub force-pushed the fixrandomaccesswritereturn branch from a8b21cc to 3fcce84 Compare July 12, 2021 16:41
@stephentoub stephentoub merged commit da7bce7 into dotnet:main Jul 12, 2021
@stephentoub stephentoub deleted the fixrandomaccesswritereturn branch July 12, 2021 23:39
adamsitnik
adamsitnik reviewed Jul 19, 2021
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finished re-reading the PR after getting back from vacation. Once again big thanks for all your help @stephentoub !

@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@karelz karelz mentioned this pull request Jul 28, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

Assignees

No one assigned

Labels

area-System.IO new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RandomAccess.Write methods should perform full writes

2 participants

@stephentoub @adamsitnik