Move DiagnosticsHandler.IsGloballyEnabled back to a method#55351
Merged
steveisok merged 2 commits intodotnet:mainfrom Jul 9, 2021
Merged
Move DiagnosticsHandler.IsGloballyEnabled back to a method#55351steveisok merged 2 commits intodotnet:mainfrom
steveisok merged 2 commits intodotnet:mainfrom
Conversation
Intent is to make linker substitutions happy
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsIntent is to make linker substitutions happy
|
Member
Author
|
@vitek-karas @eerhardt Given the current code structure, is the linker substitution going to work? |
vitek-karas
approved these changes
Jul 8, 2021
Member
vitek-karas
left a comment
vitek-karas
left a comment
There was a problem hiding this comment.
You could change it to a property, you just need to update the ILLink.Substitutions.xml for that assembly to now point to the property getter - that should work as well.
eerhardt
approved these changes
Jul 8, 2021
ManickaP
approved these changes
Jul 8, 2021
src/libraries/System.Net.Http/src/System/Net/Http/DiagnosticsHandler.cs
Outdated
Show resolved
Hide resolved
…andler.cs Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
MihaZupan
approved these changes
Jul 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent is to make linker substitutions happy and try to unblock dotnet/sdk#18801