[FileStream] add tests for device and UNC paths by adamsitnik · Pull Request #54545 · dotnet/runtime

adamsitnik · 2021-06-22T11:56:33Z

Contributes to #54495

Does the following:

tests unseekable devices by opening a FileStream using handle opened from a path pointing to a named pipe (\\.\pipe\$pipeName)
tests seekable devices by using \\.\ and \\?\ paths that use DeviceID instead of a drive letter (sth like \\.\Volume{724edb31-eaa5-4728-a4e3-f2474fd34ae2}\Users\x\AppData\Local\Temp\y\z instead C:\Users\x\AppData\Local\Temp\y\z)
tests UNC paths by creating a local file share and accessing it via \\localhost\$shareName. This requires an Admin privillige and does not work on Nano, which does not provide "netapi32.dll"

These tests are going to be failing for now, we need to merge #54483 first

ghost · 2021-06-22T11:56:41Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #54495

Does the following:

tests unseekable devices by opening a FileStream using handle opened from a path pointing to a named pipe (\\.\pipe\$pipeName)
tests seekable devices by using \\.\ and \\?\ paths that use DeviceID instead of a drive letter (sth like \\.\Volume{724edb31-eaa5-4728-a4e3-f2474fd34ae2}\Users\x\AppData\Local\Temp\y\z instead C:\Users\x\AppData\Local\Temp\y\z)
tests UNC paths by creating a local file share and accessing it via \\localhost\$shareName. This requires an Admin privillige and does not work on Nano, which does not provide "netapi32.dll"

These tests are going to be failing for now, we need to merge #54483 first

Author:	adamsitnik
Assignees:	-
Labels:	`* NO MERGE *`, `area-System.IO`
Milestone:	-

src/libraries/System.IO.FileSystem/tests/FileStream/FileStreamConformanceTests.cs

stephentoub

Thanks for adding these. There are some compilation failures, but overall the additions LGTM.

adamsitnik · 2021-06-23T07:16:11Z

/azp list

azure-pipelines · 2021-06-23T07:16:16Z

CI/CD Pipelines for this repository: coreclr-gc-longrunning coreclr-gc-simulator runtime-coreclr outerloop runtime-coreclr jitstress runtime-coreclr jitstressregs runtime-coreclr jitstress2-jitstressregs runtime-coreclr gcstress0x3-gcstress0xc runtime-coreclr gcstress-extra runtime-coreclr r2r-extra runtime-coreclr jitstress-isas-x86 runtime-coreclr jitstress-isas-arm runtime-coreclr jitstressregs-x86 runtime-coreclr libraries-jitstressregs runtime-coreclr libraries-jitstress2-jitstressregs runtime-coreclr r2r runtime-coreclr runincontext runtime-coreclr crossgen2 runtime-libraries-coreclr outerloop runtime-libraries-coreclr outerloop-windows runtime-libraries-coreclr outerloop-linux runtime-libraries-coreclr outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-dev-innerloop runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly sync-runtime-to-mono runtime-coreclr crossgen2-composite runtime-jit-experimental runtime-coreclr libraries-jitstress dotnet-linker-tests runtime-coreclr ilasm runtime-coreclr crossgen2-composite gcstress runtime-libraries-mono outerloop runtime-staging runtime-coreclr pgo runtime-coreclr libraries-pgo coreclr-gc-regions

adamsitnik · 2021-06-23T07:16:41Z

/azp run runtime-libraries-coreclr outerloop-windows

azure-pipelines · 2021-06-23T07:16:56Z

Azure Pipelines successfully started running 1 pipeline(s).

adamsitnik · 2021-06-23T08:55:10Z

/azp run runtime-libraries-coreclr outerloop-windows

azure-pipelines · 2021-06-23T08:55:23Z

Azure Pipelines successfully started running 1 pipeline(s).

adamsitnik · 2021-06-23T11:39:39Z

/azp run runtime-libraries-coreclr outerloop-windows

azure-pipelines · 2021-06-23T11:39:53Z

Azure Pipelines successfully started running 1 pipeline(s).

adamsitnik · 2021-06-23T15:00:43Z

The CI failures are unrelated (Android and System.ServiceProcess* failures from outerloop)

src/libraries/System.IO.FileSystem/tests/FileStream/FileStreamConformanceTests.Windows.cs

stephentoub

Thanks.

…bugger2 * origin/main: (107 commits) Disable MacCatalyst arm64 PR test runs on staging pipeline (dotnet#54678) [WASM] Fix async/await in config loading (dotnet#54652) Fix for heap_use_after_free flagged by sanitizer (dotnet#54679) [wasm] Bump emscripten to 2.0.23 (dotnet#53603) Fix compiler references when building inside VS (dotnet#54614) process more TLS frames at one when available (dotnet#50815) Add PeriodicTimer (dotnet#53899) UdpClient with span support (dotnet#53429) exclude fragile tests (dotnet#54671) get last error before calling a method that might fail as well (dotnet#54667) [FileStream] add tests for device and UNC paths (dotnet#54545) Fix sporadic double fd close (dotnet#54660) Remove Version.Clone from AssemblyName.Clone (dotnet#54621) [wasm] Enable fixed libraries tests (dotnet#54641) [wasm] Fix blazor/aot builds (dotnet#54651) [mono][wasm] Fix compilation error on wasm (dotnet#54659) Fix telemetry for Socket connects to Dns endpoints (dotnet#54071) [wasm] Build static components; include hot_reload in runtime (dotnet#54568) [wasm][debugger] Reuse debugger-agent on wasm debugger (dotnet#52300) Put Crossgen2 in sync with dotnet#54235 (dotnet#54438) ...

danmoseley · 2021-06-25T14:43:12Z

/backport to release/6.0-preview6

in case we want it there.

github-actions · 2021-06-25T14:43:27Z

Started backporting to release/6.0-preview6: https://github.com/dotnet/runtime/actions/runs/971756061

danmoseley · 2021-06-25T16:36:26Z

/backport to release/6.0-preview6

github-actions · 2021-06-25T16:36:39Z

Started backporting to release/6.0-preview6: https://github.com/dotnet/runtime/actions/runs/972063161

adamsitnik added 3 commits June 22, 2021 11:53

add a test for unseekable device by using a path to named pipe

0b5978a

add a test for seekable device by using DeviceID instead of drive letter

518871d

add a test for a UNC file path (local file share)

0efd744

adamsitnik added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jun 22, 2021

ghost added the area-System.IO label Jun 22, 2021

adamsitnik added this to the 6.0.0 milestone Jun 22, 2021

don't forget to remove the share

20ba569

ViktorHofer closed this Jun 22, 2021

ViktorHofer reopened this Jun 22, 2021

stephentoub reviewed Jun 23, 2021

View reviewed changes

src/libraries/System.IO.FileSystem/tests/FileStream/FileStreamConformanceTests.cs Outdated Show resolved Hide resolved

stephentoub reviewed Jun 23, 2021

View reviewed changes

adamsitnik added 2 commits June 23, 2021 08:55

Merge remote-tracking branch 'upstream/main' into devicePathTests

d1229ff

test both type of slashes in the UNC paths

a8c89fa

adamsitnik removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jun 23, 2021

adamsitnik marked this pull request as ready for review June 23, 2021 07:15

adamsitnik mentioned this pull request Jun 23, 2021

[release/6.0-preview6] [FileStream] handle UNC and device paths #54595

Merged

fix the compilation errors

47d2457

check if Server Service is running for tests that use file sharing

37675fc

adamsitnik requested a review from stephentoub June 23, 2021 15:01

stephentoub reviewed Jun 23, 2021

View reviewed changes

src/libraries/System.IO.FileSystem/tests/FileStream/FileStreamConformanceTests.Windows.cs Show resolved Hide resolved

stephentoub reviewed Jun 23, 2021

View reviewed changes

src/libraries/System.IO.FileSystem/tests/FileStream/FileStreamConformanceTests.Windows.cs Outdated Show resolved Hide resolved

stephentoub approved these changes Jun 23, 2021

View reviewed changes

address code review feedback

051d4d7

adamsitnik merged commit 7833828 into dotnet:main Jun 24, 2021

adamsitnik deleted the devicePathTests branch June 24, 2021 06:58

adamsitnik mentioned this pull request Jun 25, 2021

Increase System.IO.FileSystem test coverage #54495

Open

8 tasks

github-actions bot mentioned this pull request Jun 25, 2021

[release/6.0-preview6] [FileStream] add tests for device and UNC paths #54744

Closed

github-actions bot mentioned this pull request Jun 25, 2021

[release/6.0-preview6] [FileStream] add tests for device and UNC paths #54750

Merged

ghost locked as resolved and limited conversation to collaborators Jul 25, 2021

Conversation

adamsitnik commented Jun 22, 2021

Uh oh!

ghost commented Jun 22, 2021

Uh oh!

Uh oh!

stephentoub left a comment

Choose a reason for hiding this comment

Uh oh!

adamsitnik commented Jun 23, 2021

Uh oh!

azure-pipelines bot commented Jun 23, 2021

Uh oh!

adamsitnik commented Jun 23, 2021

Uh oh!

azure-pipelines bot commented Jun 23, 2021

Uh oh!

adamsitnik commented Jun 23, 2021

Uh oh!

azure-pipelines bot commented Jun 23, 2021

Uh oh!

adamsitnik commented Jun 23, 2021

Uh oh!

azure-pipelines bot commented Jun 23, 2021

Uh oh!

adamsitnik commented Jun 23, 2021

Uh oh!

Uh oh!

Uh oh!

stephentoub left a comment

Choose a reason for hiding this comment

Uh oh!

danmoseley commented Jun 25, 2021

Uh oh!

github-actions bot commented Jun 25, 2021

Uh oh!

danmoseley commented Jun 25, 2021

Uh oh!

github-actions bot commented Jun 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants