[wasm] Enable more networking tests by pavelsavara · Pull Request #53027 · dotnet/runtime

pavelsavara · 2021-05-20T14:04:20Z

System.Net.Http\tests\FunctionalTests is now included in tests
I moved System.Net.Http.Functional.Tests and System.Net.WebSockets.Client.Tests to run in chrome instead of V8 via WasmTestOnBrowser
I used [ActiveIssue] [wasm] Enable crypto and related tests #37669 for missing crypto MD5
I used [ActiveIssue] Runtime developer can run Networking tests without Loopback server capability (on mobile/browser platforms) #42852 for loopback support
I used [ActiveIssue] [wasm][HTTP] TypeError: Failed to execute 'fetch' on 'Window': Request with GET/HEAD method cannot have body #53591 - GET/HEAD method cannot have body
I used [ActiveIssue] [wasm][HTTP] TypeError: Failed to execute 'fetch' on 'Window': 'TRACE' HTTP method is unsupported. #53592 - 'TRACE' HTTP method is unsupported.
I used [ActiveIssue] [wasm][HTTP] TypeError: Failed to fetch #53018 - Failed to fetch
I used [ActiveIssue] [mono][windows] System.Net.Sockets.SocketException : Unknown error (0xffffffff) #53281 for WebSocket problems on Mono/Windows
I used [SkipOnPlatform] when I was confident that we do not plan to support the feature
Fixed IsMsQuicSupported to return bool instead of throwing

ghost · 2021-05-20T14:04:26Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Author:	pavelsavara
Assignees:	-
Labels:	`area-System.Net`
Milestone:	-

ghost · 2021-05-20T14:05:05Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Author:	pavelsavara
Assignees:	-
Labels:	`arch-wasm`, `area-System.Net`
Milestone:	-

akoeplinger · 2021-05-20T14:53:36Z

/azp run runtime-libraries-mono outerloop

azure-pipelines · 2021-05-20T14:53:47Z

Azure Pipelines successfully started running 1 pipeline(s).

src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj

src/libraries/System.Net.Http/tests/FunctionalTests/HttpContentTest.cs

pavelsavara · 2021-05-20T15:06:54Z

/azp run runtime-libraries-mono outerloop

azure-pipelines · 2021-05-20T15:07:07Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-05-20T18:50:03Z

/azp run runtime-libraries-mono outerloop

azure-pipelines · 2021-05-20T18:50:15Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-05-21T14:15:38Z

/azp run runtime-libraries-mono outerloop

azure-pipelines · 2021-05-21T14:15:49Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-05-24T10:49:14Z

/azp run runtime-libraries-mono outerloop

azure-pipelines · 2021-05-24T10:49:25Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-05-24T13:17:02Z

/azp run runtime-libraries-mono outerloop

azure-pipelines · 2021-05-24T13:17:13Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-05-24T16:32:01Z

/azp run runtime-libraries-mono outerloop

azure-pipelines · 2021-05-24T16:32:16Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-05-25T17:00:24Z

/azp run runtime-libraries-mono outerloop

pavelsavara · 2021-06-02T11:06:33Z

for System.Net.WebSockets.Client.Tests it's Condition not met: WebSocketsSupported in 100% cases
for Common.Tests you were right, we could keep it in normal scenario.
for System.Net.Http.Functional.Tests I marked it as wasmtestonbrowser.
I created [wasm][HTTP] TypeError: Failed to execute 'fetch' on 'Window': Request with GET/HEAD method cannot have body #53591 and [wasm][HTTP] TypeError: Failed to execute 'fetch' on 'Window': 'TRACE' HTTP method is unsupported. #53592 with more specific error details for the tests which have specific failure

pavelsavara · 2021-06-02T11:09:59Z

is this zero?

For System.Net.WebSockets.Client.Tests yes.
For System.Net.Http.Functional.Tests V8 need to skip the same 78 tests as browser, but for different reason. I made that distinction explicit.

I don't believe we need to split this into 2 PRs

pavelsavara · 2021-06-02T11:20:16Z

/azp run runtime-libraries-mono outerloop

azure-pipelines · 2021-06-02T11:20:28Z

Azure Pipelines successfully started running 1 pipeline(s).

- fix Quic detection in test - disable webSocket tests on Mono/Windows - enable System.Net.Http.Functional.Tests on browser - disable tests with MaxConnectionsPerServer not supported on Browser - disable tests with Socket not supported on Browser - disable tests with AutomaticDecompression not supported on Browser - disable tests with UseProxy not supported on Browser

- disable tests with Credentials is not supported on Browser - disable tests with Loopback server

- [ActiveIssue] dotnet#37669 for missing crypto MD5

…Browser to allow System.Net.Http.Functional.Tests pass on V8

…a WasmTestOnBrowser

- disabled tests with dotnet#53591 - disabled tests with dotnet#53592

pavelsavara · 2021-06-02T13:23:42Z

/azp run runtime-libraries-mono outerloop

azure-pipelines · 2021-06-02T13:23:54Z

Azure Pipelines successfully started running 1 pipeline(s).

...raries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTestBase.SocketsHttpHandler.cs

src/libraries/Common/tests/System/Net/Http/PostScenarioTest.cs

radical

Thanks for addressing the feedback. Assuming everything passes, LGTM, thanks 👍

pavelsavara · 2021-06-02T15:52:59Z

/azp run runtime-libraries-mono outerloop

azure-pipelines · 2021-06-02T15:53:11Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost added the area-System.Net label May 20, 2021

pavelsavara requested a review from akoeplinger May 20, 2021 14:04

pavelsavara added the arch-wasm WebAssembly architecture label May 20, 2021

pavelsavara changed the title ~~[wasm] Enable networking tests in outerloop~~ [wasm] Enable more networking tests May 20, 2021

pavelsavara force-pushed the pr_wasm_outerloop branch from b710e57 to f5b4b2f Compare May 20, 2021 14:40

This comment has been minimized.

Sign in to view

akoeplinger reviewed May 20, 2021

View reviewed changes

src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj Outdated Show resolved Hide resolved

akoeplinger reviewed May 20, 2021

View reviewed changes

src/libraries/System.Net.Http/tests/FunctionalTests/HttpContentTest.cs Outdated Show resolved Hide resolved

pavelsavara force-pushed the pr_wasm_outerloop branch from 5fd0aa8 to 9de8296 Compare May 21, 2021 14:13

pavelsavara force-pushed the pr_wasm_outerloop branch from 0fe76eb to 9dac530 Compare May 24, 2021 10:47

pavelsavara force-pushed the pr_wasm_outerloop branch from 650c203 to 0ef56f9 Compare May 24, 2021 16:30

pavelsavara force-pushed the pr_wasm_outerloop branch from 0ef56f9 to eb3c674 Compare May 25, 2021 16:59

pavelsavara mentioned this pull request Jun 2, 2021

Runtime developer can run Networking tests without Loopback server capability (on mobile/browser platforms) #42852

Closed

7 tasks

pavelsavara added 8 commits June 2, 2021 15:21

- disable tests with PreAuthenticate not supported on Browser

ca37463

- disable tests with Credentials is not supported on Browser - disable tests with Loopback server

- run outerloop on browser, rather than V8 only

5efbadc

- [ActiveIssue] dotnet#37669 for missing crypto MD5

- conditional tests with PlatformDetection.IsBrowserDomSupportedOrNot…

8071147

…Browser to allow System.Net.Http.Functional.Tests pass on V8

- System.Net.Http.Functional.Tests to run in chrome instead of V8 vi…

9d52c23

…a WasmTestOnBrowser

- disabled tests with dotnet#53018

951f5b9

- disabled tests with dotnet#53591 - disabled tests with dotnet#53592

- ActiveIssue dotnet#34690 for WebSocket on Windows Mono

7a54f94

fix pipeline

eec12ef

pavelsavara force-pushed the pr_wasm_outerloop branch from 1a16223 to eec12ef Compare June 2, 2021 13:23

pavelsavara requested a review from radical June 2, 2021 13:54

radical reviewed Jun 2, 2021

View reviewed changes

...raries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTestBase.SocketsHttpHandler.cs Outdated Show resolved Hide resolved

radical reviewed Jun 2, 2021

View reviewed changes

src/libraries/Common/tests/System/Net/Http/PostScenarioTest.cs Outdated Show resolved Hide resolved

pavelsavara added 2 commits June 2, 2021 17:19

feedback

8441f72

feedback

319a339

radical approved these changes Jun 2, 2021

View reviewed changes

pavelsavara merged commit 1e19518 into dotnet:main Jun 2, 2021

pavelsavara mentioned this pull request Jun 3, 2021

[wasm][http] BrowserHttpHandler.SendAsync - JavaScript host object 'Headers' not found #52969

Closed

karelz mentioned this pull request Jun 17, 2021

[wasm] SendReceive_VaryingLengthBuffers_Success failing in CI #53957

Closed

ghost locked as resolved and limited conversation to collaborators Jul 2, 2021

karelz added this to the 6.0.0 milestone Jul 15, 2021

pavelsavara deleted the pr_wasm_outerloop branch July 29, 2021 08:50

Conversation

pavelsavara commented May 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented May 20, 2021

Uh oh!

ghost commented May 20, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

akoeplinger commented May 20, 2021

Uh oh!

azure-pipelines bot commented May 20, 2021

Uh oh!

Uh oh!

Uh oh!

pavelsavara commented May 20, 2021

Uh oh!

azure-pipelines bot commented May 20, 2021

Uh oh!

pavelsavara commented May 20, 2021

Uh oh!

azure-pipelines bot commented May 20, 2021

Uh oh!

pavelsavara commented May 21, 2021

Uh oh!

azure-pipelines bot commented May 21, 2021

Uh oh!

pavelsavara commented May 24, 2021

Uh oh!

azure-pipelines bot commented May 24, 2021

Uh oh!

pavelsavara commented May 24, 2021

Uh oh!

azure-pipelines bot commented May 24, 2021

Uh oh!

pavelsavara commented May 24, 2021

Uh oh!

azure-pipelines bot commented May 24, 2021

Uh oh!

pavelsavara commented May 25, 2021

Uh oh!

pavelsavara commented Jun 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pavelsavara commented Jun 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pavelsavara commented Jun 2, 2021

Uh oh!

azure-pipelines bot commented Jun 2, 2021

Uh oh!

pavelsavara commented Jun 2, 2021

Uh oh!

azure-pipelines bot commented Jun 2, 2021

Uh oh!

Uh oh!

Uh oh!

radical left a comment

Choose a reason for hiding this comment

Uh oh!

pavelsavara commented Jun 2, 2021

Uh oh!

azure-pipelines bot commented Jun 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pavelsavara commented May 20, 2021 •

edited

Loading

pavelsavara commented Jun 2, 2021 •

edited

Loading

pavelsavara commented Jun 2, 2021 •

edited

Loading