Revert "Handle casts done via helpers and fold overflow operations value numbering (#50450)"#51401
Conversation
… value numbering (dotnet#50450)" This reverts commit 730abc9.
|
This LGTM. However, is there a smaller change we can make to just block the new functionality enabled by the PR rather than reverting the entire thing? If not, that's fine. |
|
I think so, yes, there is a small change that I could make here (block folding for all UB casts, not just checked ones, in Note on the formatting failure:
this is the second time I am seeing this... |
|
The jit-format on windows x64 failed due to an infrastructure glitch: |
|
I asked that the Formatting x64 task be re-run, and it acknowledges it but I didn't see it start the re-run. |
|
The Linux release failures issue this message:
This is a known failure:" #51372 |
This is causing too many failures for me to investigate in time (#51381, #51380), so reverting the change wholesale.
I am planning to revisit this with the approach of not folding UB casts.
Note that UB means Undefined Behavior
cc @BruceForstall, @tannergooding