Revert "Disable Net5CompatFileStream by default (#50166)"#51142
Revert "Disable Net5CompatFileStream by default (#50166)"#51142carlossanlop wants to merge 2 commits intodotnet:mainfrom carlossanlop:RevertNet5CompatFS
Conversation
This reverts commit 8b2ad5b to unblock dotnet/sdk.
|
Tagging subscribers to this area: @carlossanlop Issue DetailsPartially addresses #51141 Unblocks dotnet/sdk#16810 This reverts commit 8b2ad5b to unblock dotnet/sdk.
|
adamsitnik
left a comment
There was a problem hiding this comment.
@carlossanlop thank you for doing this! I hope to have a bug fix tomorrow
jeffhandley
left a comment
There was a problem hiding this comment.
Thanks, @carlossanlop. Out of curiosity, could we alternatively enable the compat switch in the SDK project(s) to unblock that build? Or do you think there are too many projects affected by the bug right now?
I am unsure of the impact on other repos. We think it's safer at this point having this change reverted, do our tests again, make sure the issue is reproduced locally, and get it fixed before we turn on the compat switch by default again. |
|
Makes sense; thanks! |
|
I have a fix, please don't merge this PR ;) |
|
Fix of the actual bug: #51151 |
|
Thanks Adam! If the CI in your PR finishes successfully, we will merge that. Otherwise, we'll merge this PR. |
Partially addresses #51141
Unblocks dotnet/sdk#16810
This reverts commit 8b2ad5b to unblock dotnet/sdk.