Track trailing zeros only for floating point numbers#48608
Merged
7 commits merged intodotnet:masterfrom Feb 26, 2021
Merged
Conversation
|
Tagging subscribers to this area: @tannergooding, @pgovind |
pgovind
commented
Feb 22, 2021
src/libraries/System.Private.CoreLib/src/System/Number.Parsing.cs
Outdated
Show resolved
Hide resolved
jeffhandley
approved these changes
Feb 26, 2021
Member
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
LGTM but of course needs @tannergooding's signoff too.
| } | ||
|
|
||
| [Theory] | ||
| [InlineData("3.00")] |
Member
There was a problem hiding this comment.
I assume this is one of the tests we would expect to add a much longer list of values to in the future, per our recent discussion about adding much more comprehensive tests in this area.
|
Hello @pgovind! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
tannergooding
approved these changes
Feb 26, 2021
ghost
merged commit 
Member
|
/backport to release/6.0-preview2 |
Contributor
|
Started backporting to release/6.0-preview2: https://github.com/dotnet/runtime/actions/runs/604327471 |
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48604 and #48648
This change also reduces the scope of #47666. With this change, we now track trailing zeros only for
FloatingPointformats. As a result, this change also fixes decimal->string roundtripping bug that 47666 introduced.