Turn Debugger.Log, Debugger.Launch, and Delegate.BindToMethodName to QCalls

[hoyosjs]

• Port Convert Debugger.Log and Debugger.Launch to QCalls #46617: Convert Debugger.Log and Debugger.Launch to QCalls

Some changes to add the BEGIN_QCALL/END_QCALL macros.

• Convert BindToMethodName to QCall

Uses same helper as Debugger.Log, so convert too.

[ghost]

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• Port Convert Debugger.Log and Debugger.Launch to QCalls #46617: Convert Debugger.Log and Debugger.Launch to QCalls

Some changes to add the BEGIN_QCALL/END_QCALL macros.

• Convert BindToMethodName to QCall

Uses same helper as Debugger.Log

Author:	hoyosjs
Assignees:	-
Labels:	area-Diagnostics-coreclr
Milestone:	-

[hoyosjs]

I haven't ported the other call (ValidateObject), but wanted to get a feel if this is what we need to do. Will open the 3.1 PR after this. I am currently testing this locally.

[jkotas]

Convert BindToMethodName to QCall

It may be useful to make this change in master first, and then port it to servicing.

[jkotas]

You still have to protect the GC references like before. Number of the calls below triggers GC - it is not ok to have unprotected GC reference in a local while calling GC triggering method.

The easiest way to do this is to keep the gc struct and use GCPROTECT_BEGIN/END macro to protect it.

It may be possible to avoid GCPROTECT_BEGIN/END and instead re-fetch the value each time from ObjectHandleOnStack. It would be more involved change.

[jkotas]

I think this shows that we should do the change in dotnet/runtime first so that subtle GC holes (if there are any) will show up as intermittent crashes in CI. The servicing CI runs much less often and so these bugs would take a lot longer to surface.

[hoyosjs]

I will do this on master first, I just can't turn this into draft, so I continued working here first.

[jkotas]

I think we should go with your fix #45906 for servicing, instead of this change. #45906 turned out simple enough to make it low-risk.

[hoyosjs]

@jkotas yeah. I am closing this one.