Turn off PGO builds until I can get a proper fix in#48170
Merged
agocke merged 1 commit intodotnet:masterfrom Feb 12, 2021
Merged
Turn off PGO builds until I can get a proper fix in#48170agocke merged 1 commit intodotnet:masterfrom
agocke merged 1 commit intodotnet:masterfrom
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ViktorHofer
approved these changes
Feb 11, 2021
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
LGTM if that's sufficient to fix the manifest errors.
|
Hello @agocke! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Member
Author
|
It should be -- the errors only happen because pgort is present in the output, but I think (checked locally) that pgort doesn't get copied in the regular builds. |
Member
Author
|
Looks like just a flaky networking test, merging |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the fix here is to make the artifacts include pgo info in the name so the builds don't cross each other, but that may take a few tries to get right.