Skip to content

Comments

[browser] Fix System.Delegate.DynamicInvoke method can not be resolved#47519

Merged
marek-safar merged 23 commits intodotnet:masterfrom
kjpou1:wasm-fix-delegate-trimming
Feb 10, 2021
Merged

[browser] Fix System.Delegate.DynamicInvoke method can not be resolved#47519
marek-safar merged 23 commits intodotnet:masterfrom
kjpou1:wasm-fix-delegate-trimming

Conversation

@kjpou1
Copy link
Contributor

@kjpou1 kjpou1 commented Jan 27, 2021 •
edited
Loading

  • When building an app using <PublishTrimmed>true</PublishTrimmed> the linker is linking out System.Delegate.DynamicInvoke
  • Call Delegate Invoke directly

Remove dependency on System.Delegate.DynamicInvoke

  • Explicitly provide the declaring type to GetMethodFromHandle in GetCallSignature
  • Fixes error resolving generic method handles. 
       Error: System.ArgumentException: Cannot resolve method Int32 Invoke(Int32, Int32) because the declaring type of the method handle System.Func`3[T1,T2,TResult] is generic. Explicitly provide the declaring type to GetMethodFromHandle.

Add method to retrieve the Invoke method of the delegate

Added delegate tests.

Fix #47516

@kjpou1
[browser] Fix System.Delegate.DynamicInvoke method can not be resolved
377a8e4 
- When building an app using <PublishTrimmed>true</PublishTrimmed> the linker is linking out System.Delegate.DynamicInvoke
- Add this to the linker trim exclusions.
@ghost
Copy link

ghost commented Jan 27, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@kjpou1 kjpou1 self-assigned this Jan 27, 2021
@kjpou1 kjpou1 added the arch-wasm WebAssembly architecture label Jan 27, 2021
@ghost
Copy link

ghost commented Jan 27, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • When building an app using true the linker is linking out System.Delegate.DynamicInvoke
  • Add this to the linker trim exclusions.
Author: kjpou1
Assignees: kjpou1
Labels:

arch-wasm
Milestone: -

@kjpou1 kjpou1 added this to the 6.0.0 milestone Jan 27, 2021
@kjpou1 kjpou1 requested a review from marek-safar January 27, 2021 13:57
@kjpou1
Change this back to mscorlib as the recommended code cause a warning.
84c0ba6 
```
resource System.Private.Runtime.InteropServices.JavaScript.xml in System.Private.Runtime.InteropServices.JavaScript, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a : warning IL2007: Could not resolve assembly 'System.Private.CoreLib' [/src/libraries/System.Private.Runtime.InteropServices.JavaScript/src/System.Private.Runtime.InteropServices.JavaScript.csproj]
    1 Warning(s)
    0 Error(s)
```
kjpou1 added 7 commits January 29, 2021 05:16
@kjpou1
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
e6e8d34 
…fix-delegate-trimming
@kjpou1
[browser] Remove linker trim exclusions for System.Delegate.DynamicIn…
ab9ae20 
…voke
@kjpou1
Remove dependency on System.Delegate.DynamicInvoke
2070cb5 
- Explicitly provide the declaring type to GetMethodFromHandle in GetCallSignature
- Fixes error resolving generic method handles.
   ```
      Error: System.ArgumentException: Cannot resolve method Int32 Invoke(Int32, Int32) because the declaring type of the method handle System.Func`3[T1,T2,TResult] is generic. Explicitly provide the declaring type to GetMethodFromHandle.
   ```
@kjpou1
Add method to retrieve the Invoke method of the delegate
255be2f
@kjpou1
Create another test module for Delegate tests
7203cbf
@kjpou1
Add MarshalFunctionReturnAction that marshals an Action delegate from…
cbbcbd9 
… a Function
@kjpou1
More tests, Actions and Delegate methods
7145696
@kjpou1 kjpou1 requested a review from eerhardt January 29, 2021 11:06
@lewing lewing requested review from kg, lambdageek and radical January 30, 2021 03:58
This was referenced Feb 1, 2021
Closed
Closed
radical
radical reviewed Feb 1, 2021
View reviewed changes
radical
radical reviewed Feb 1, 2021
View reviewed changes
@kjpou1 kjpou1 requested a review from radical February 2, 2021 10:54
@kjpou1
Copy link
Contributor Author

kjpou1 commented Feb 4, 2021

@marek-safar @lewing @radical

@kjpou1 kjpou1 mentioned this pull request Feb 5, 2021
Closed
@kjpou1
Merge branch 'master' of https://github.com/dotnet/runtime into wasm-…
6ac1cb8 
…fix-delegate-trimming

# Conflicts:
#	src/libraries/System.Private.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Runtime.cs
@kjpou1
Fix accessor after merge conflict
b1f78ad
@marek-safar marek-safar merged commit eab1b43 into dotnet:master Feb 10, 2021
@kjpou1 kjpou1 deleted the wasm-fix-delegate-trimming branch February 10, 2021 10:49
@runfoapp runfoapp bot mentioned this pull request Feb 10, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safar marek-safar marek-safar approved these changes

@lewing lewing Awaiting requested review from lewing

@steveisok steveisok Awaiting requested review from steveisok

@eerhardt eerhardt Awaiting requested review from eerhardt

@kg kg Awaiting requested review from kg

@lambdageek lambdageek Awaiting requested review from lambdageek

@radical radical Awaiting requested review from radical

Assignees

@kjpou1 kjpou1

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

[browser] Uncaught Error: System.Delegate.DynamicInvoke method can not be resolved.

5 participants

@kjpou1 @radical @kg @marek-safar @eerhardt