Harmonize ReceiveMessageFrom tests and bring them back to Inner Loop#46862
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsContributes to #41502 and #43845 by making the tests for All old
All the
|
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsContributes to #41502 and #43845 by making the tests for All old
All the
|
src/libraries/System.Net.Sockets/tests/FunctionalTests/ReceiveMessageFrom.cs
Outdated
Show resolved
Hide resolved
geoffkizer
left a comment
There was a problem hiding this comment.
LGTM -- one minor comment above
|
This is nice to see, thanks. |
Contributes to #41502 and #43845 by making the tests for
ReceiveMessageFromeasier maintain and extend, harmonizing them under theSocketTestHelperinfrastructure similarly to the code inSendReceive.csAll old
ReceiveMessageFrom.csandReceiveMessageFromAsync.cstests have been refactored toReceiveMessageFrom<T>and subclasses:ReceiveMessageFrom<T>.ReceiveSentMessages_Successreplace the following old tests:ReceiveMessageFrom.Success,ReceiveMessageFrom.Success_IPv6,ReceiveMessageFrom.Success_APM,ReceiveMessageFromAsync.ReceiveSentMessages_Tasks_SuccessReceiveMessageFrom<T>.ReceiveSentMessages_ReuseEventArgs_Successserve as a replacement for:ReceiveMessageFrom.Success_EventArgs,ReceiveMessageFromAsync.ReceiveSentMessages_SocketAsyncEventArgs_Success. These 2 were more or less duplicates, except that latter served as a regression test for Fix lifetime handling of ReceiveMessageFromAsync buffer on Windows corefx#22012 by setting the buffer multiple times. The new test case keeps exercising this behavior. (Note: I also tried to alter between different buffer modes using the sameSocketAsyncEventArgsinstance, which made me to discover ReceiveMessageFrom does not work correctly on Linux after altering BufferList to a single buffer #46860.)All the
ReceiveMessageFromtests are brought back to inner loop, since there's no reason to keep them in outer loop. They were pushed out in dotnet/corefx#11341 as part of an umbrella operation to stabilize networking tests. I'm not aware of any instabilities caused byReceiveMessageFromruns.