Fix assert(isByteReg(ireg)).#46567
Merged
sandreenko merged 1 commit intodotnet:masterfrom Jan 6, 2021
Merged
Conversation
Contributor
Author
|
/azp run runtime-coreclr outerloop, runtime-coreclr jitstressregs |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
PTAL @dotnet/jit-contrib , cc @jkoritzinsky |
Contributor
Author
|
/azp run runtime-coreclr jitstressregs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BruceForstall
approved these changes
Jan 5, 2021
kunalspathak
approved these changes
Jan 5, 2021
Contributor
Author
Contributor
Author
|
The failures in the stress job are covered by #46085. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a similar code in the non-multi reg case:
runtime/src/coreclr/jit/lsrabuild.cpp
Lines 3380 to 3386 in 867ba80
so repeat the logic for MultiReg.
When we do a call we then copy the arguments to the temp location and we should choose registers that can be used in byte instructions on x86.
Fixes #46277.
No diffs.