Skip to content

Fix a few spelling mistakes#45930

Merged
lewing merged 1 commit intodotnet:masterfrom
eerhardt:FixSpelling
Dec 11, 2020
Merged

Fix a few spelling mistakes#45930
lewing merged 1 commit intodotnet:masterfrom
eerhardt:FixSpelling

Conversation

@eerhardt
Copy link
Member

paramterless => parameterless
Polymorhic => Polymorphic

paramterless => parameterless
Polymorhic => Polymorphic
@ghost
Copy link

ghost commented Dec 10, 2020

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

paramterless => parameterless
Polymorhic => Polymorphic

Author: eerhardt
Assignees: -
Labels:

area-System.Reflection-mono

Milestone: -

{
PublicParameterizedConstructorTestClass paramterless = PublicParameterizedConstructorTestClass.Instance;
Assert.Equal("{\"Name\":\"42\"}", JsonSerializer.Serialize(paramterless));
PublicParameterizedConstructorTestClass parameterless = PublicParameterizedConstructorTestClass.Instance;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you detect these or did you happen to just run across them ad-hoc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny story - my tests were broken in #45911, and I noticed that the exception message coming from mono had this spelling issue. So I grepped the whole repo for the same spelling error and this came up.

Then my eye caught the "Polymorphic" spelling mistake below, so I figured I had to fix that as well, while I was in here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good old grepping for a string with a typo :)

@lewing lewing merged commit 56f5a0d into dotnet:master Dec 11, 2020
@eerhardt eerhardt deleted the FixSpelling branch December 11, 2020 15:09
@ghost ghost locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-VM-reflection-mono Reflection issues specific to MonoVM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants