A couple of small LSRA modifications#43116
Closed
CarolEidt wants to merge 2 commits intodotnet:masterfrom
Closed
Conversation
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
CarolEidt
force-pushed
the
LsraSmallMods
branch
from
2498714 to
f311b78
Compare
- Fix an incorrect short-circuit for bestPossibleScore - Don't set delayRegFree on an operand that is the same as the one in the RMW position, and one of them is a last use. - Add REG_LR to the REG_VAR_ORDER - Other misc. changes.
CarolEidt
force-pushed
the
LsraSmallMods
branch
from
f311b78 to
01fa5ca
Compare
Member
|
// Auto-generated message 69e114c which was merged 12/7 removed the intermediate src/coreclr/src/ folder. This PR needs to be updated as it touches files in that directory which causes conflicts. To update your commits you can use this bash script: https://gist.github.com/ViktorHofer/6d24f62abdcddb518b4966ead5ef3783. Feel free to use the comment section of the gist to improve the script for others. |
Contributor
|
I verified the changes in this PR and all of them were ported and merged in #45135. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes have minor impact, but make it easier to achieve zero diffs when changing how the heuristics are computed.