Fix handling of repo analyzers and warnings-as-errors #42272
Merged
stephentoub merged 5 commits intodotnet:masterfrom Sep 17, 2020
Merged
Fix handling of repo analyzers and warnings-as-errors #42272stephentoub merged 5 commits intodotnet:masterfrom
stephentoub merged 5 commits intodotnet:masterfrom
Conversation
stephentoub
requested review from
EgorBo,
akoeplinger,
marek-safar,
steveisok and
vargaz
as code owners
ViktorHofer
reviewed
Sep 15, 2020
ViktorHofer
approved these changes
Sep 15, 2020
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
Besides my one question this looks great. Thanks a lot
stephentoub
force-pushed
the
fixwarnings
branch
from
7503ecb to
9d45cba
Compare
danmoseley
approved these changes
Sep 16, 2020
Contributor
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
Thanks for doing this! I love getting to zero warnings!
I would suggest triggering the
runtime-coreclr outerloop job to see what the coreclr Pri-1 test build looks like.
Looks like the coreclr test wrappers are failing to build now
AaronRobinsonMSFT
approved these changes
Sep 16, 2020
marek-safar
reviewed
Sep 16, 2020
src/mono/wasm/debugger/BrowserDebugHost/BrowserDebugHost.csproj
Outdated
Show resolved
Hide resolved
marek-safar
reviewed
Sep 16, 2020
src/mono/wasm/debugger/BrowserDebugProxy/BrowserDebugProxy.csproj
Outdated
Show resolved
Hide resolved
stephentoub
force-pushed
the
fixwarnings
branch
from
9d45cba to
dba6621
Compare
When we brought in the new SDK, it enabled analyzers by default (which then used our custom ruleset), but a bunch of projects (in particular tests) weren't expecting that, such that we now have thousands of warnings in the repo. This opts-out those projects. It also enables warnings-as-errors at the root level of the repo, to hopefully avoid such warning storms in the future, and to also clean up the remaining that exist. This includes a bunch of new obsoletion and platform compat warnings that are firing in the runtime tests. We may choose to run analyzers on additional projects in the future where it's currently disabled, but this gets us back to a state at least as good if not better than we were previously.
Fixes the warnings that were triggered by our rule set applying to this project. All fixes were automated.
stephentoub
force-pushed
the
fixwarnings
branch
from
dba6621 to
97e38d8
Compare
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Member
Author
|
@BruceForstall, how do I trigger your recommended leg? |
Member
|
It is to be done manually from AzDO UI:
|
Member
Author
|
Thanks, @jkotas. And it looks like you kicked it off; cool. |
marek-safar
approved these changes
Sep 17, 2020
Member
Author
|
Failures are outerloop coreclr test failures rather than build failures due to warnings-as-errors. Official build also passed. |
8 tasks
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42184
cc: @jkotas, @ViktorHofer, @BruceForstall