Crossgen2 composite GC stress pipeline#39949
Merged
trylek merged 3 commits intodotnet:masterfrom Jul 29, 2020
Merged
Conversation
BruceForstall
approved these changes
Jul 27, 2020
Contributor
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
That LGTM.
However, if you're trying to run crossgen2 compiles without excessively slow stress modes, you might also want to save/restore COMPlus_HeapVerify, and maybe COMPlus_ReadyToRun. There are other things that also run slow, like COMPlus_JITMinOpts, but perhaps not enough to worry about it.
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @dotnet/crossgen-contrib
I have a first reasonable run at
https://dev.azure.com/dnceng/public/_build/results?buildId=746207&view=results
after I fixed the CLRTest.Crossgen2.targets script to suppress the GC stress mode for the duration of Crossgen2 compilation, otherwise it seems to me that the "dotnet" command used to run Crossgen2 silently picks up the COMPlus variable and runs Crossgen2 itself in GC stress mode, causing impractical compilation times and work item timeouts left and right. The script modification hopefully also
Fixes: #39933
Thanks
Tomas