Skip to content

Comments

Add PlatformNotSupportedException for Browser version of System.Net.Sockets#39346

Merged
marek-safar merged 2 commits intodotnet:masterfrom
marek-safar:sockets
Jul 15, 2020
Merged

Add PlatformNotSupportedException for Browser version of System.Net.Sockets#39346
marek-safar merged 2 commits intodotnet:masterfrom
marek-safar:sockets

Conversation

@marek-safar
Copy link
Contributor

@marek-safar marek-safar commented Jul 15, 2020

@ghost
Copy link

ghost commented Jul 15, 2020

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

@steveisok steveisok mentioned this pull request Jul 15, 2020
Closed
99 tasks
@MaximLipnin
Copy link
Contributor

MaximLipnin commented Jul 15, 2020 •
edited
Loading

This will require:

  1. removing <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Net.Sockets\tests\FunctionalTests\System.Net.Sockets.Tests.csproj" /> from tests.proj file;
  2. adding [assembly: SkipOnMono("System.Net.Sockets is not supported on Browser", TestPlatforms.Browser)] to System.Net.Sockets/tests/FunctionalTests/AssemblyInfo.cs
  3. perhaps, adding <IgnoreForCI Condition="'$(TargetOS)' == 'Browser'">true</IgnoreForCI> to System.Net.Sockets.Tests.csproj

@marek-safar marek-safar merged commit c3a817e into dotnet:master Jul 15, 2020
@marek-safar marek-safar deleted the sockets branch July 15, 2020 14:49
@MaximLipnin MaximLipnin mentioned this pull request Jul 28, 2020
Merged
akoeplinger pushed a commit that referenced this pull request Jul 29, 2020
@MaximLipnin
[wasm] Re-enable some tests in the System.Net.WebSockets.Tests namesp…
6ab00b4 
…ace (#40004)

There is no repro for #38807 at the moment so the related tests have been enabled.
Two tests have been disabled due to PNSE (see #39346).

Fixes: #38807 

The test run result: `Tests run: 177, Errors: 0, Failures: 0, Skipped: 0.`
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@MaximLipnin @Jacksondr5
[wasm] Re-enable some tests in the System.Net.WebSockets.Tests namesp…
6f99b23 
…ace (dotnet#40004)

There is no repro for dotnet#38807 at the moment so the related tests have been enabled.
Two tests have been disabled due to PNSE (see dotnet#39346).

Fixes: dotnet#38807 

The test run result: `Tests run: 177, Errors: 0, Failures: 0, Skipped: 0.`
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees

No one assigned

Labels

area-System.Net.Sockets

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@marek-safar @MaximLipnin @akoeplinger @karelz @Dotnet-GitSync-Bot