WASM: Fix System.Diagnostics.TraceSource tests#39224
Merged
akoeplinger merged 2 commits intodotnet:masterfrom Jul 14, 2020
Merged
WASM: Fix System.Diagnostics.TraceSource tests#39224akoeplinger merged 2 commits intodotnet:masterfrom
akoeplinger merged 2 commits intodotnet:masterfrom
Conversation
One test was using `Assembly.GetEntryAssembly()` which returns null on WebAssembly. Others are testing that the output contains the stacktrace but it is empty on WASM right now.
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
99 tasks
stephentoub
reviewed
Jul 13, 2020
src/libraries/System.Diagnostics.TraceSource/tests/TraceClassTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jul 13, 2020
Co-authored-by: Stephen Toub <stoub@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One test was using
Assembly.GetEntryAssembly()which returns null on WebAssembly.Others are testing that the output contains the stacktrace but it is empty on WASM right now.