WASM enable System.Collections.Specialized.Tests#39012
Merged
safern merged 1 commit intodotnet:masterfrom Jul 10, 2020
Merged
Conversation
|
Tagging subscribers to this area: @eiriktsarpalis |
99 tasks
safern
force-pushed
the
wasm-systemcollectionsspecializedtests
branch
from
868b463 to
168b6e7
Compare
Member
Author
|
cc: @GrabYourPitchforks these tests might be using I'll mark this as NO-MERGE in order to do all as part of this PR once your PR is merged. |
safern
added
the
NO-MERGE
Member
|
@safern shouldn't we get this enabled without blocking on the BinaryFormatter PR? I'd imagine we can just fix any issues there. |
Member
Author
Yeah, based on the offline conversation we had, it is fine to merge. |
safern
removed
the
NO-MERGE
akoeplinger
approved these changes
Jul 9, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests are passing after: #38948
Contributes towards: #38422
cc: @steveisok @akoeplinger