Disable failing Windows arm32 tests#38844
Merged
BruceForstall merged 1 commit intodotnet:masterfrom Jul 7, 2020
Merged
Conversation
BruceForstall
added
area-CodeGen-coreclr
stephentoub
approved these changes
Jul 7, 2020
kunalspathak
reviewed
Jul 7, 2020
Contributor
kunalspathak
left a comment
kunalspathak
left a comment
There was a problem hiding this comment.
I didn't see these test failing without JitStress flags. Are they being disable so they don't get run in JitStress mode?
Contributor
Author
Yes. We don't have the ability (that I know of) to disable for a particular OS + architecture + stress mode combination, so disabling just for OS + architecture seems like a better option than disabling for JitStress. |
Contributor
Author
|
Windows x86 'pauseonstart' failure is known: #38847 |
kunalspathak
added a commit
to kunalspathak/runtime
that referenced
this pull request
Jul 7, 2020
This reverts commit 311fd81.
kunalspathak
added a commit
that referenced
this pull request
Jul 8, 2020
* logging * the fix * revert lclvars.cpp changes * Revert "revert lclvars.cpp changes" This reverts commit d39af7084687e8fe5e6d4f71674ec84d36a88340. * wip * revert lclvars.cpp changes * deleted inst_RV_ST() * removing logging, added some asserts * jit-formatting * add back case of INS_add and some more asserts * reset lclvars.cpp * delete comments and cleanup code * revert changes inside common.il * Revert "Disable failing Windows arm32 tests (#38844)" This reverts commit 311fd81. * review comments * added standard function header
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #36199