Since FileSystemWatcher is not supported on wasm, throw PNSE and skip tests#38368
Merged
marek-safar merged 2 commits intodotnet:masterfrom Jun 25, 2020
Merged
Since FileSystemWatcher is not supported on wasm, throw PNSE and skip tests#38368marek-safar merged 2 commits intodotnet:masterfrom
marek-safar merged 2 commits intodotnet:masterfrom
Conversation
stephentoub
reviewed
Jun 25, 2020
| @@ -0,0 +1,241 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
Member
There was a problem hiding this comment.
Instead of manually implementing the PNSE-stubbed-out version, could we get tooling to do it for us? e.g.
https://github.com/dotnet/runtime/search?q=GeneratePlatformNotSupportedAssemblyMessage&unscoped_q=GeneratePlatformNotSupportedAssemblyMessage
Member
Author
There was a problem hiding this comment.
Learn something new every day ;-).
lewing
reviewed
Jun 25, 2020
Member
lewing
left a comment
lewing
left a comment
There was a problem hiding this comment.
I know we haven't been very consistent with naming but should this be FileSystemWatcher.Browser.cs or FileSystemWatcher.NotSuppported.cs instead?
marek-safar
approved these changes
Jun 25, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.